Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov process #3336

Merged
merged 2 commits into from
Jan 19, 2025
+29 −31
Merged

update codecov process #3336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955ae59
update codecov process
hirosassa Jan 18, 2025
35d0b48
fix codecov.yml
hirosassa Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
51 changes: 24 additions & 27 deletions .github/workflows/pythonbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
tox-env: py312-core

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip
uses: actions/cache@v2
uses: actions/cache@v4
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
Expand All @@ -52,12 +52,11 @@ jobs:
env:
TOXENV: ${{ matrix.tox-env }}
run: tox
- name: Codecov
env:
COVERAGE_PROCESS_START: .coveragerc
run: |
pip install codecov
codecov -e ${{ matrix.tox-env }}
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
verbose: true

postgres:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -94,13 +93,13 @@ jobs:
tox-env: py312-postgres

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip
uses: actions/cache@v2
uses: actions/cache@v4
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
Expand All @@ -116,12 +115,11 @@ jobs:
env:
TOXENV: ${{ matrix.tox-env }}
run: tox
- name: Codecov
env:
COVERAGE_PROCESS_START: .coveragerc
run: |
pip install codecov
codecov -e ${{ matrix.tox-env }}
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
verbose: true

base:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -198,13 +196,13 @@ jobs:
tox-env: docs

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip
uses: actions/cache@v2
uses: actions/cache@v4
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
Expand All @@ -218,10 +216,9 @@ jobs:
TOXENV: ${{ matrix.tox-env }}
OVERRIDE_SKIP_CI_TESTS: ${{ matrix.OVERRIDE_SKIP_CI_TESTS }}
run: tox
- name: Codecov
- name: Upload coverage to Codecov
if: ${{ matrix.tox-env != 'flake8' && matrix.tox-env != 'docs' }}
env:
COVERAGE_PROCESS_START: .coveragerc
run: |
pip install codecov
codecov -e ${{ matrix.tox-env }}
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
verbose: true
5 changes: 3 additions & 2 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ coverage:
default: false # disable the default status that measures entire project
core:
target: 92%
paths: "luigi/*.py"
paths:
- "luigi/*.py"
patch: # Just copied from default
default:
if_no_uploads: error

changes: true # Just copied from default

ignore:
- "examples/"
- "luigi/tools" # These are tested as actual run commands without coverage
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ envlist = py{37,38,39,310,311,312}-{cdh,hdp,core,contrib,apache,aws,gcloud,postg
skipsdist = True

[pytest]
addopts = --cov=luigi -vv --strict-markers --ignore-glob="**/_*" --fulltrace
addopts = --cov=luigi --cov-report=xml -vv --strict-markers --ignore-glob="**/_*" --fulltrace
testpaths = test
markers =
contrib: tests related to luigi/contrib
Expand Down
Loading