-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update codecov process #3336
update codecov process #3336
Conversation
Take a look at the Github Action results. Failures with the codecov changes. |
1379d07
to
955ae59
Compare
@dlstadther Thanks for your comment! Could you please review this PR? |
CI execution looks good and can confirm that codecov received the test coverage results. However, unrelated to your change (i think), it looks like CodeCov is complaining about the validity of the luigi conf yaml file. Though, the yaml indentation that codecov reports looks different than the https://app.codecov.io/github/spotify/luigi/commit/955ae591ab201e270552d002723a08534a31d8ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for this contribution and for your quick and effective fixes!
The master build is now failing because codecov's upload is requiring a token for protected branches...
Odd how the old cli execution was able to upload coverage, but this method can't. Otherwise, we may need to involve a Spotify employee who has admin rights to help. |
Description
In this PR, I replaced
codecov
process to official github action.Motivation and Context
codecov
command is currently deprecated.ref: https://docs.codecov.com/docs/about-the-codecov-bash-uploader
Have you tested this? If so, how?
Fixed CI worked.