fix(auto-edit): Fix low resolution images on low DPI screens #7100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
force-pushed
the
tr/img-pixel-ratio
branch
from
f62b1a2 to
247d708
Compare
umpox
force-pushed
the
tr/img-pixel-ratio
branch
from
686408c to
dd2afc1
Compare
hitesh-1997
reviewed
Feb 17, 2025
valerybugakov
approved these changes
Feb 17, 2025
| @@ -173,11 +172,15 @@ export function drawDecorationsToCanvas( | |||
| const canvasWidth = Math.min(requiredWidth + config.padding.x, config.maxWidth) | |||
| const canvasHeight = tempYPos + config.padding.y | |||
|
|
|||
| // Round to the nearest pixel, using sub-pixels will cause CanvasKit to crash | |||
There was a problem hiding this comment.
Interesting, is it expected? 😃
There was a problem hiding this comment.
Nope, didn't find many issues online about it either but it's hard to search because CanvasKit is just a small part of Skia which is a much bigger project (used for rendering Chrome/Android UIs etc).
Thankfully the image tests work really well here and help catch any regressions
abeatrix
pushed a commit
that referenced
this pull request
Feb 17, 2025
…creens (#7112) ### Description closes https://linear.app/sourcegraph/issue/CODY-4995/image-appears-blurred-on-large-screen-compared-to-text closes https://linear.app/sourcegraph/issue/CODY-4924/auto-edit-improve-image-resolution ### Screenshots (Low DPI Display) **This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95** **Before** <img width="662" alt="image" src="https://github.com/user-attachments/assets/97f11290-c41d-478f-bc8c-a95c179edc5b" /> **After** <img width="663" alt="image" src="https://github.com/user-attachments/assets/072e9822-7aaa-41fb-bd5d-65c506599d8b" /> ### Screenshots (High DPI Display) **This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95** **Before** <img width="646" alt="image" src="https://github.com/user-attachments/assets/d960e8d7-5ea6-4402-a748-fab9e21869c3" /> **After** <img width="647" alt="image" src="https://github.com/user-attachments/assets/d75cb094-5314-478e-a3b9-c6897c43b569" /> ## Test plan - Tested on a low DPI display with the default pixel ratio of 1.95 - Tested on a low DPI display with the actual pixel ratio - Tested on a high DPI display with the default pixel ratio of 1.95 - Tested on a high DPI display with the actual pixel ratio <br> Backport d21d2b7 from #7100 Co-authored-by: Tom Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes https://linear.app/sourcegraph/issue/CODY-4995/image-appears-blurred-on-large-screen-compared-to-text
closes https://linear.app/sourcegraph/issue/CODY-4924/auto-edit-improve-image-resolution
Screenshots (Low DPI Display)
This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95
Before
After
Screenshots (High DPI Display)
This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95
Before
After
Test plan