Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport M70] fix(auto-edit): Fix low resolution images on low DPI screens #7112

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

sourcegraph-release-bot
Copy link
Collaborator

Description

closes https://linear.app/sourcegraph/issue/CODY-4995/image-appears-blurred-on-large-screen-compared-to-text
closes https://linear.app/sourcegraph/issue/CODY-4924/auto-edit-improve-image-resolution

Screenshots (Low DPI Display)

This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95

Before
<img width="662" alt="image" src="https://github.com/user-attachments/assets/97f11290-c41d-478f-bc8c-a95c179edc5b" />

After
<img width="663" alt="image" src="https://github.com/user-attachments/assets/072e9822-7aaa-41fb-bd5d-65c506599d8b" />

Screenshots (High DPI Display)

This is without the progressive enhancement, i.e. using the default pixel ratio of 1.95

Before
<img width="646" alt="image" src="https://github.com/user-attachments/assets/d960e8d7-5ea6-4402-a748-fab9e21869c3" />

After
<img width="647" alt="image" src="https://github.com/user-attachments/assets/d75cb094-5314-478e-a3b9-c6897c43b569" />

Test plan

  • Tested on a low DPI display with the default pixel ratio of 1.95
  • Tested on a low DPI display with the actual pixel ratio
  • Tested on a high DPI display with the default pixel ratio of 1.95
  • Tested on a high DPI display with the actual pixel ratio


Backport d21d2b7 from #7100

### Description

closes
https://linear.app/sourcegraph/issue/CODY-4995/image-appears-blurred-on-large-screen-compared-to-text
closes
https://linear.app/sourcegraph/issue/CODY-4924/auto-edit-improve-image-resolution

### Screenshots (Low DPI Display)

**This is without the progressive enhancement, i.e. using the default
pixel ratio of 1.95**

**Before**
<img width="662" alt="image"
src="https://github.com/user-attachments/assets/97f11290-c41d-478f-bc8c-a95c179edc5b"
/>

**After**
<img width="663" alt="image"
src="https://github.com/user-attachments/assets/072e9822-7aaa-41fb-bd5d-65c506599d8b"
/>

### Screenshots (High DPI Display)

**This is without the progressive enhancement, i.e. using the default
pixel ratio of 1.95**

**Before**
<img width="646" alt="image"
src="https://github.com/user-attachments/assets/d960e8d7-5ea6-4402-a748-fab9e21869c3"
/>

**After**
<img width="647" alt="image"
src="https://github.com/user-attachments/assets/d75cb094-5314-478e-a3b9-c6897c43b569"
/>

## Test plan

- Tested on a low DPI display with the default pixel ratio of 1.95
- Tested on a low DPI display with the actual pixel ratio
- Tested on a high DPI display with the default pixel ratio of 1.95
- Tested on a high DPI display with the actual pixel ratio

<!-- Required. See
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->

(cherry picked from commit d21d2b7)
@sourcegraph-release-bot sourcegraph-release-bot requested review from umpox and a team February 17, 2025 12:40
@umpox umpox requested a review from abeatrix February 17, 2025 15:09
@abeatrix abeatrix merged commit a230bf7 into M70 Feb 17, 2025
22 of 23 checks passed
@abeatrix abeatrix deleted the backport-7100-to-M70 branch February 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants