live-preview: Make property widgets use less information #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the property widgets work with less information avaiable to them. I hope I can reuse them for runtime widget state as well that way. Unexport the individual widgets and wrap them into a `PropertyValueWidget` that switches between them as needed -- and fills in the extra information needed to keep the existing functionality in place. This makes the PropertyView so much cleaner ;-)
hunger
force-pushed
the
tobias/push-opnkoqttmznw
branch
from
e03eb14 to
7ea00e9
Compare
szecket
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the property widgets work with less information avaiable to them. I hope I can reuse them for runtime widget state as well that way.
Unexport the individual widgets and wrap them into a
PropertyValueWidgetthat switches between them as needed -- and fills in the extra information needed to keep the existing functionality in place.This makes the PropertyView so much cleaner ;-)