-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test agains latest Scylla #4306
Draft
Michal-Leszczynski
wants to merge
6
commits into
master
Choose a base branch
from
ml/fix-4303
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
481541f
to
b7c0b8c
Compare
It's always better to analyze the newest Scylla behavior by default. It also doesn't make us bump this version once in a while.
We should be testing SM against latest Scylla in order to detect problems with integration faster.
b7c0b8c
to
49b961f
Compare
…se image This commit extends the way in which the testing images is built with commands suitable for ubi-9-minimal Scylla base image. Fixes #4303
4da72db
to
1f9e986
Compare
Some tests execute commands on scylla nodes over ssh, and some of them need small alterations, so that they work on ubi-9-minimal Scylla base images. This commit also improves the implementation of timeout related tests.
We haven't been supporting ansible script restore for a long time, so we don't need to keep on testing it.
For now, scylla-nightly:latest image is bugged and fails to soft restart, so we need to use other Scylla which: - has tablet API host filtering features - is based on ubi 9 minimal image - does not fail on soft restart Ref scylladb/scylladb#23353
1f9e986
to
0f989e0
Compare
@karol-kokoszka This PR is ready, but we need to wait for scylladb/scylladb#23353 to get fixed before replacing the hand picked Scylla version with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we are testing against some hand picked Scylla version instead of
scylla-nightly:latest
, because it is bugged (see scylladb/scylladb#23353). This version is based on ubi 9 minimal image and contains tablet repair API filtering, so it should be enough to verify that SM test env is ready for ubi 9 minimal Scylla images.Fixes #4303