Improve documentation of various gap-related methods #39905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
gap-improve-doc
branch
from
f32e829 to
fbc3629
Compare
user202729
force-pushed
the
gap-improve-doc
branch
from
fbc3629 to
f29bd6d
Compare
This was referenced Apr 8, 2025
|
Documentation preview for this PR (built with commit f29bd6d; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title.
There will be no visible change to the user because these methods all start with
_, only to Sage developers.The reason is… there's a lot of confusion in downstream implementations, so it looks like whoever initially wrote that code wasn't aware of the convention. See #39908 .
📝 Checklist
⌛ Dependencies