Remove confusion in gap interface conversion method #39909
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the documentation changes in the issue below for an explanation why this change is correct. Basically
_gap_
must take in an interface object and return element of that object; while_libgap_
must take no argument and return libgap element.Also make
IncidenceStructure
inherit fromSageObject
— as noted in the documentation ofSageObject
, all objects visible to the user ought to inherit from it.📝 Checklist
⌛ Dependencies
#39905
Not strictly necessary, but useful to see why this change is correct.