Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusion in gap interface conversion method #39909

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Apr 8, 2025

See the documentation changes in the issue below for an explanation why this change is correct. Basically _gap_ must take in an interface object and return element of that object; while _libgap_ must take no argument and return libgap element.

Also make IncidenceStructure inherit from SageObject — as noted in the documentation of SageObject, all objects visible to the user ought to inherit from it.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#39905

Not strictly necessary, but useful to see why this change is correct.

Copy link

github-actions bot commented Apr 8, 2025

Documentation preview for this PR (built with commit c7eedd8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant