Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-docs: Update Cloud API spec #986

Open
wants to merge 1 commit into
base: api
Choose a base branch
from
Open

Conversation

vbotbuildovich
Copy link
Contributor

@vbotbuildovich vbotbuildovich commented Feb 25, 2025

This PR updates the OpenAPI spec file for the Cloud API.
Triggered by commit: 5c94992f5631fb12161c2529ee28288853b7e2fe

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit d2633e9
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/67d81e5cf0adfe0008015a5d
😎 Deploy Preview https://deploy-preview-986--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kbatuigas
Copy link
Contributor

Need to confirm with Cloud team regarding these changes

@vbotbuildovich vbotbuildovich force-pushed the update-branch-api branch 5 times, most recently from 9422b96 to 395548c Compare March 6, 2025 15:42
@kbatuigas
Copy link
Contributor

Working with API team to make sure data plane specs are up to date and correct for v1, and that there is a way to group/separate out control plane v1beta2 (in the absence of versioned API docs).

@vbotbuildovich vbotbuildovich force-pushed the update-branch-api branch 2 times, most recently from b500386 to 7cc45e4 Compare March 10, 2025 19:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status update:

  • no blockers on the control plane side
  • spoke with @bojand and v1 for data plane was merged in Console today, and the next release is scheduled for next Monday the 17th. That should get v1 data plane integrated into Cloud, which should bring in the correct updates for the data plane API specs via GH Actions (update the endpoint paths to v1 and remove the unwanted changes to the fields specified in this current diff).
  • We also talked about grouping the v1 and v1alpha2 tags in the same way as in the Control Plane, which is the quickest and easiest way to denote which endpoints belong to each respective version in the absence of versioned API docs. I plan to open a PR in Console to update the tag names.

@kbatuigas
Copy link
Contributor

kbatuigas commented Mar 11, 2025

Status update:

Per today's Cloud API sync, we will modify the control plane and data plane OpenAPI files so that they contain only v1 endpoints. Awaiting this change from Engineering/cloudv2. When we get the files in this import, we can merge this PR and redpanda-data/cloud-docs#211 as well.

@@ -1117,6 +1117,11 @@ components:
$ref: '#/components/schemas/Pipeline.State'
status:
$ref: '#/components/schemas/Pipeline.Status'
url:
description: |-
URL to connect to the pipeline, e.g. via http_server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
URL to connect to the pipeline, e.g. via http_server.
URL to connect to the pipeline, for example, using http_server.

Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kbatuigas
Copy link
Contributor

Status update:

Data plane all set, awaiting updated v1-only specs for control plane which should come within this week. redpanda-data/cloud-docs#211 is ready once all updated specs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants