Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cloud API for RBAC #211

Merged

Conversation

kbatuigas
Copy link
Contributor

@kbatuigas kbatuigas commented Feb 24, 2025

.## Description

This pull request adds new documentation for managing RBAC (Role-Based Access Control) in the control plane. The changes include instructions for listing role bindings, getting role bindings, getting user details, creating role bindings, and creating service accounts.

New RBAC management documentation:

  • Added a section on managing RBAC configurations, including assigning roles to users and service accounts.
  • Provided examples of API requests for listing role bindings, getting role bindings, and getting user details.

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline: 27 Feb 2025

Page previews

Use Control Plane API with BYOC > Manage RBAC

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit f259a39
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/67d1ab863b50d9000725ef05
😎 Deploy Preview https://deploy-preview-211--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


[,bash]
----
curl "https://api.redpanda.com/v1alpha1/role-bindings?filter.role_name=<role-name>&filter.scope.resource_type=SCOPE_RESOURCE_TYPE_CLUSTER" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint has multiple filters available. Are there certain filters that we want to call out or provide examples for in the docs? We should base these on the most relevant and helpful use cases.

@kbatuigas kbatuigas marked this pull request as ready for review February 25, 2025 17:24
@kbatuigas kbatuigas requested a review from a team as a code owner February 25, 2025 17:24
@kbatuigas kbatuigas requested a review from sago2k8 February 25, 2025 17:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kat this is good however @Mateoc is working on v1, could we write the docs only for iamv1 so customers go only to the v1


=== Get role binding

To see roles assignments for a specific IAM account, make a GET request to the xref:api:ROOT:cloud-controlplane-api.adoc#get-/v1alpha1/role-bindings/-id-[`/v1alpha1/role-bindings/\{id}`] endpoint, passing the role binding ID as a parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To see roles assignments for a specific IAM account, make a GET request to the xref:api:ROOT:cloud-controlplane-api.adoc#get-/v1alpha1/role-bindings/-id-[`/v1alpha1/role-bindings/\{id}`] endpoint, passing the role binding ID as a parameter.
To see roles assignments for a specific IAM account, make a GET request to the xref:api:ROOT:cloud-controlplane-api.adoc#get-/v1alpha1/role-bindings/-id-[`/v1role-bindings/\{id}`] endpoint, passing the role binding ID as a parameter.

this is an example

@kbatuigas kbatuigas force-pushed the DOC-1012-Cloud-Add-RBAC-to-Use-the-Control-Plane-API-doc branch from 32b8b1b to 1bbdecb Compare March 7, 2025 18:35
@kbatuigas
Copy link
Contributor Author

This is blocked until we can get the imported specs (redpanda-data/docs#986) corrected so that v1beta2 versus v1 endpoints are clearly indicated (we don't support versioned API docs yet), and data plane specs are updated to the v1 endpoints.

@kbatuigas kbatuigas requested a review from sago2k8 March 10, 2025 21:56
@kbatuigas
Copy link
Contributor Author

Status update:

@sago2k8 has helped to unblock this PR on the control plane side - redpanda-data/docs#986 now includes updated tag names for v1beta2 to more clearly indicate the beta endpoints. Investigating a way to group the tags as v1 versus v1beta2 so that v1 endpoints are listed in the reference first, but not a blocker for this PR. Just need @sago2k8 's and Docs team approval before end of this week.

Copy link
Contributor

@sago2k8 sago2k8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left couple of comments

kbatuigas and others added 2 commits March 11, 2025 13:16
Co-authored-by: Santiago Jimenez Giraldo <[email protected]>
@kbatuigas kbatuigas requested a review from sago2k8 March 11, 2025 17:17
@micheleRP
Copy link
Contributor

@kbatuigas please make sure to add a blurb to What's New that Cloud API is now GA

@micheleRP
Copy link
Contributor

The beta tag still needs to be removed from the top-level Cloud API index page.

@micheleRP
Copy link
Contributor

@kbatuigas In the Cloud Overview here, will you please remove Cloud API from the list of features in beta?

Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the 3 comments I left for little updates, then looks good!

@micheleRP
Copy link
Contributor

@kbatuigas please also doublecheck for v1alpha1, like here!

@kbatuigas
Copy link
Contributor Author

This is ready to merge as soon as updated specs (redpanda-data/docs#986) are in.

@kbatuigas kbatuigas merged commit f841eae into main Mar 20, 2025
5 checks passed
@kbatuigas kbatuigas deleted the DOC-1012-Cloud-Add-RBAC-to-Use-the-Control-Plane-API-doc branch March 20, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants