Use ITestOutputHelper instead of Console.WriteLine #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
reviewed
Feb 5, 2025
assemblies-valid/AssembliesValid.cs
Outdated
| @@ -40,30 +41,37 @@ public class AssembliesValid | |||
| new Regex("/packs/"), | |||
| }; | |||
|
|
|||
| private readonly ITestOutputHelper output; | |||
tmds
approved these changes
Feb 5, 2025
Messages logged by tests to the console using Console.WriteLine and Console.Error.WriteLine are not captured by newer versions of the .NET SDK. Instead, they get lost. So we get no real feedback for failing tests in logs. Messages logged by ITestOutputHelper are captured by the test runner, and automatically displayed by the test runner for failing tests. They don't get displayed for passing tests out of the box, but can be displayed by configuring the test logger.
omajid
force-pushed
the
console-output-save
branch
from
c2cf422 to
b171d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages logged by tests to the console using Console.WriteLine and Console.Error.WriteLine are not captured by newer versions of the .NET SDK. Instead, they get lost. So we get no real feedback for failing tests in logs.
Messages logged by ITestOutputHelper are captured by the test runner, and automatically displayed by the test runner for failing tests. They don't get displayed for passing tests out of the box, but can be displayed by configuring the test logger.
See #370 for more discussion about the need for this.