Use ITestOutputHelper instead of Console.WriteLine

Messages logged by tests to the console using Console.WriteLine and
Console.Error.WriteLine are not captured by newer versions of the .NET
SDK. Instead, they get lost. So we get no real feedback for failing
tests in logs.

Messages logged by ITestOutputHelper are captured by the test runner,
and automatically displayed by the test runner for failing tests. They
don't get displayed for passing tests out of the box, but can be
displayed by configuring the test logger.

Author: omajid

assemblies-valid/AssembliesValid.cs

@@ -11,6 +11,7 @@
 using System.Text;
 using System.Text.RegularExpressions;
 using Xunit;
+using Xunit.Abstractions;
 
 namespace AssembliesValid
 {
@@ -40,30 +41,37 @@ public class AssembliesValid
             new Regex("/packs/"),
         };
 
+        private readonly ITestOutputHelper output;
+
+        public AssembliesValid(ITestOutputHelper output)
+        {
+            this.output = output;
+        }
+
         [Fact]
         public void ValidateAssemblies()
         {
             string dotnetPath = null;
             int exitCode = RunProcessAndGetOutput(new string[] { "bash", "-c", "command -v dotnet" }, out dotnetPath);
             if (exitCode != 0)
             {
-                Console.Error.WriteLine("'dotnet' command not found");
-                Console.Error.WriteLine("PATH: " + Environment.GetEnvironmentVariable("PATH"));
+                output.WriteLine("'dotnet' command not found");
+                output.WriteLine("PATH: " + Environment.GetEnvironmentVariable("PATH"));
                 Assert.True(false);
             }
             dotnetPath = dotnetPath.Trim();
             exitCode = RunProcessAndGetOutput(new string[] { "readlink", "-f", dotnetPath }, out dotnetPath);
             if (exitCode != 0)
             {
-                Console.Error.WriteLine($"Unable to run readlink -f {dotnetPath}");
+                output.WriteLine($"Unable to run readlink -f {dotnetPath}");
                 Assert.True(false);
             }
             dotnetPath = dotnetPath.Trim();
 
             string searchRoot = new FileInfo(dotnetPath).DirectoryName;
             var searchRootDirectory = new System.IO.DirectoryInfo(searchRoot);
 
-            Console.WriteLine($"Searching for dotnet binaries in {searchRoot}");
+            output.WriteLine($"Searching for dotnet binaries in {searchRoot}");
 
             var architecture = RuntimeInformation.OSArchitecture;
             var machine = GetCurrentMachine(architecture);
@@ -106,11 +114,11 @@ public void ValidateAssemblies()
 
                         if (valid)
                         {
-                            Console.WriteLine($"{assembly}: OK");
+                            output.WriteLine($"{assembly}: OK");
                         }
                         else
                         {
-                            Console.WriteLine($"error: {assembly} hasMethods: {hasMethods}, hasAot: {hasAot}, inReleaseMode: {inReleaseMode}");
+                            output.WriteLine($"error: {assembly} hasMethods: {hasMethods}, hasAot: {hasAot}, inReleaseMode: {inReleaseMode}");
                             allOkay = false;
                         }
                     }

version-apis/VersionTest.cs

@@ -3,26 +3,34 @@
 using System.Runtime.InteropServices;
 using System.Text.RegularExpressions;
 using Xunit;
+using Xunit.Abstractions;
 
 namespace DotNetCoreVersionApis
 {
     public class VersionTest
     {
         public static readonly int MAX_DOTNET_MAJOR_VERSION = 10;
 
+        private readonly ITestOutputHelper output;
+
+        public VersionTest(ITestOutputHelper output)
+        {
+            this.output = output;
+        }
+
         [Fact]
         public void EnvironmentVersion()
         {
             var version = Environment.Version;
-            Console.WriteLine($"Environment.Version: {version}");
+            output.WriteLine($"Environment.Version: {version}");
             Assert.InRange(version.Major, 3, MAX_DOTNET_MAJOR_VERSION);
         }
 
         [Fact]
         public void RuntimeInformationFrameworkDescription()
         {
             var description = RuntimeInformation.FrameworkDescription;
-            Console.WriteLine($"RuntimeInformation.FrameworkDescription: {description}");
+            output.WriteLine($"RuntimeInformation.FrameworkDescription: {description}");
             Assert.StartsWith(".NET", description);
         }
 
@@ -31,11 +39,11 @@ public void RuntimeInformationFrameworkDescription()
         [InlineData("corefx", typeof(Uri))]
         public void CommitHashesAreAvailable(string repo, Type type)
         {
-            Console.WriteLine($"Testing commit hashes for {repo}");
+            output.WriteLine($"Testing commit hashes for {repo}");
 
             var attributes = (AssemblyInformationalVersionAttribute[])type.Assembly.GetCustomAttributes(typeof(AssemblyInformationalVersionAttribute),false);
             var versionAttribute = attributes[0];
-            Console.WriteLine($"AssemblyInformationVersionAttribute: {versionAttribute.InformationalVersion}");
+            output.WriteLine($"AssemblyInformationVersionAttribute: {versionAttribute.InformationalVersion}");
 
             string[] versionParts = versionAttribute.InformationalVersion.Split("+");
             Assert.Equal(2, versionParts.Length);