Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split gitops resources in their own namespace #108

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 6, 2025

Starting with RHTAP installer 1.5, GitOps has its own namespace to better segregate its resources.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Starting with RHTAP installer 1.5, GitOps has its own namespace to
better segregate its resources.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 requested review from otaviof and lcarva February 6, 2025 20:05
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Contributor

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to define rhtap-gitops as Helm template variable, so we could avoid copying and pasting this attribute over many files.

/lgtm

@Roming22
Copy link
Member Author

Would be great to define rhtap-gitops as Helm template variable, so we could avoid copying and pasting this attribute over many files.

Those files are generated by scripts/import-samples, so there's is no requirement to copy/paste the value.

@lcarva lcarva merged commit 1f0816a into redhat-appstudio:main Feb 10, 2025
5 checks passed
@Roming22 Roming22 deleted the feat/ns-split branch February 11, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants