Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy dh and gitops in their own namespaces #445

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Feb 6, 2025

There's no good reason for the 2 services to share the same namespace. This change helps with segregation of services. This in turn helps with development, as it guarantee that there is no unknown link between the 2 services and one can reset a service by deleting the namespace and redeploying the cluster.

With this change, the rhtap namespace becomes a location for integration secrets.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@Roming22
Copy link
Member Author

Roming22 commented Feb 6, 2025

The CI will fail until redhat-appstudio/tssc-sample-templates#108 is merged.

@redhat-appstudio redhat-appstudio deleted a comment from openshift-ci bot Feb 6, 2025
@redhat-appstudio redhat-appstudio deleted a comment from openshift-ci bot Feb 6, 2025
@Roming22 Roming22 marked this pull request as draft February 7, 2025 14:17
@otaviof
Copy link
Collaborator

otaviof commented Feb 10, 2025

/retest

@Roming22 Roming22 marked this pull request as ready for review February 11, 2025 03:42
@openshift-ci openshift-ci bot requested a review from jkopriva February 11, 2025 03:42
@Roming22 Roming22 force-pushed the feat/dh-gitops-split branch from c56c307 to 60e8fcc Compare February 11, 2025 03:43
Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xinredhat
Copy link
Member

/retest

2 similar comments
@Roming22
Copy link
Member Author

/retest

@rhopp
Copy link
Contributor

rhopp commented Feb 11, 2025

/retest

There's no good reason for the 2 services to share the same namespace.
This change helps with segregation of services. This in turn helps with
development, as it guarantee that there is no unknown link between the
2 services and one can reset a service by deleting the namespace and
redeploying the cluster.

With this change, the `rhtap` namespace becomes a location for
integration secrets.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22 Roming22 force-pushed the feat/dh-gitops-split branch from 60e8fcc to d2b0266 Compare February 11, 2025 12:51
@Roming22
Copy link
Member Author

/retest

@konflux-ci-qe-bot
Copy link

@Roming22: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.16-4vg9r Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-4vg9r

Test results analysis

<not enabled>

@rhopp
Copy link
Contributor

rhopp commented Feb 11, 2025

Initial version of PR for fixing e2e tests is ready (redhat-appstudio/rhtap-e2e#226, but it needs to be tested more - and as there is no way how to test PRs from rhtap-cli and rhtap-e2e, I'm +1 for merging this one and I'll make sure the rhtap-e2e tests are updated asap.

@Roming22
Copy link
Member Author

Forcing merge as per @rhopp comment.

@Roming22 Roming22 merged commit 44728b5 into redhat-appstudio:main Feb 11, 2025
9 of 11 checks passed
@Roming22 Roming22 deleted the feat/dh-gitops-split branch February 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants