-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deploy dh and gitops in their own namespaces #445
Conversation
ebc9d1f
to
c56c307
Compare
The CI will fail until redhat-appstudio/tssc-sample-templates#108 is merged. |
/retest |
c56c307
to
60e8fcc
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
There's no good reason for the 2 services to share the same namespace. This change helps with segregation of services. This in turn helps with development, as it guarantee that there is no unknown link between the 2 services and one can reset a service by deleting the namespace and redeploying the cluster. With this change, the `rhtap` namespace becomes a location for integration secrets. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
60e8fcc
to
d2b0266
Compare
|
/retest |
@Roming22: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.16-4vg9r Test results analysis<not enabled> |
Initial version of PR for fixing e2e tests is ready (redhat-appstudio/rhtap-e2e#226, but it needs to be tested more - and as there is no way how to test PRs from rhtap-cli and rhtap-e2e, I'm +1 for merging this one and I'll make sure the rhtap-e2e tests are updated asap. |
Forcing merge as per @rhopp comment. |
There's no good reason for the 2 services to share the same namespace. This change helps with segregation of services. This in turn helps with development, as it guarantee that there is no unknown link between the 2 services and one can reset a service by deleting the namespace and redeploying the cluster.
With this change, the
rhtap
namespace becomes a location for integration secrets.rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED