Syncing latest changes from master for noobaa-operator

.github/workflows/manual-build.yml

@@ -21,7 +21,7 @@ jobs:
           ref: ${{ github.event.inputs.branch }}
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Get Current Date
         id: date

.github/workflows/releaser.yaml

@@ -26,7 +26,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.17
+          go-version: 1.21
       - name: Release
         env:
           GITHUB_TOKEN: ${{ secrets.GHACTION_TOKEN_WRITE }}
@@ -45,4 +45,4 @@ jobs:
           bash build/tools/builder.sh --oci-org $OCI_ORG --gh-org noobaa --gh-repo noobaa-operator || exit 1
           bash build/tools/releaser.sh --oci-org $OCI_ORG --gh-org noobaa --gh-repo noobaa-operator || exit 1
       # - name: "Krew Release"
-      #   uses: rajatjindal/[email protected]
+      #   uses: rajatjindal/[email protected]

.github/workflows/run_admission_test.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Setup Go on runner
         uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_ci.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-go@v2 # Could not change to version 3, see issue:
         # https://github.com/noobaa/noobaa-operator/issues/1031
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Deploy Dependencies
         id: deploy
@@ -52,7 +52,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Deploy Dependencies
         id: deploy
@@ -81,7 +81,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v2
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Deploy Dependencies
         id: deploy

.github/workflows/run_cosi_test.yaml

@@ -20,7 +20,7 @@ jobs:
       - name: Setup Go on runner
         uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_hac_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_azure_vault_test.yml

@@ -0,0 +1,43 @@
+name: KMS Test - Azure Vault
+on: [push, pull_request, workflow_dispatch]
+
+jobs:
+  run-azure-vault-test:
+    runs-on: ubuntu-latest
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4
+      - uses: actions/setup-go@v4
+        with:
+          go-version: "1.21"
+
+      - name: Set environment variables
+        run: |
+          echo PATH=$PATH:$HOME/go/bin                                          >> $GITHUB_ENV
+          echo OPERATOR_IMAGE=localhost:5000/noobaa/noobaa-operator:integration >> $GITHUB_ENV
+
+      - name: Deploy Dependencies
+        run: |
+          set -x
+          bash .travis/install-5nodes-kind-cluster.sh
+          go get -v github.com/onsi/ginkgo/ginkgo
+          go install -mod=mod -v github.com/onsi/ginkgo/ginkgo
+          ginkgo version
+
+      - name: Build NooBaa
+        run: |
+          make cli
+          make image
+          docker tag noobaa/noobaa-operator:$(go run cmd/version/main.go) $OPERATOR_IMAGE
+          docker push $OPERATOR_IMAGE
+
+      - name: Install NooBaa
+        run: |
+          bash  .travis/install-noobaa-pull-azure-parameters.sh
+
+      - name: Run KMS Azure test
+        run: make test-kms-azure-vault

.github/workflows/run_kms_dev_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_ibm_kp_test.yml

@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_kmip_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_rotate_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_tls_sa_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/run_kms_tls_token_test.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Set environment variables
         run: |

.github/workflows/testing.yml

@@ -13,7 +13,7 @@ jobs:
         uses: actions/checkout@v4
       - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: "1.21"
 
       - name: Get Current Date
         id: date

.travis/install-noobaa-pull-azure-parameters.sh

@@ -0,0 +1,13 @@
+#!/bin/sh
+set -o errexit
+
+
+# TODO: Replace it with azure key vault URL once we have Azure key vault
+# account is created
+echo AZURE_VAULT_URL="https://noobaa-vault.vault.azure.net/" >> $GITHUB_ENV
+
+echo "💬 Install NooBaa CRD"
+./build/_output/bin/noobaa-operator-local crd create
+
+echo "💬 Create NooBaa operator deployment"
+./build/_output/bin/noobaa-operator-local operator --operator-image=$OPERATOR_IMAGE install

Makefile

@@ -24,8 +24,8 @@ else
 GOBIN=$(shell go env GOBIN)
 endif
 
-CONTROLLER_GEN_VERSION=v0.12.0
-DEEPCOPY_GEN_VERSION=v0.27.0
+CONTROLLER_GEN_VERSION=v0.14.0
+DEEPCOPY_GEN_VERSION=v0.29.3
 
 GO_LINUX ?= GOOS=linux GOARCH=amd64
 GOHOSTOS ?= $(shell go env GOHOSTOS)
@@ -240,6 +240,11 @@ test-kms-tls-token: vendor
 	@echo "✅ test-kms-tls-token"
 .PHONY: test-kms-tls-token
 
+test-kms-azure-vault: vendor
+	ginkgo -v pkg/util/kms/test/azure-vault
+	@echo "✅ test-kms-azure-vault"
+.PHONY: test-kms-azure-vault
+
 test-kms-ibm-kp: vendor
 	ginkgo -v pkg/util/kms/test/ibm-kp
 	@echo "✅ test-kms-ibm-kp"
@@ -310,4 +315,4 @@ ifneq ($(DEEPCOPY_GEN_VERSION), $(shell deepcopy-gen --version | awk -F ":" '{pr
 DEEPCOPY_GEN=$(GOBIN)/deepcopy-gen
 else
 DEEPCOPY_GEN=$(shell which deepcopy-gen)
-endif
+endif

README.md

@@ -138,7 +138,6 @@ $ noobaa options
 ```
 The following options can be passed to any command:
 
-
     --admission=false: Install the system with admission validation webhook
     --autoscaler-type='': The type of autoscaler (hpav2, keda)
     --aws-sts-arn='': The AWS STS Role ARN which will assume role
@@ -165,11 +164,12 @@ The following options can be passed to any command:
     --pg-ssl-unauthorized=false: Allow the client to work with self-signed ssl (external postgres - server-side)
     --postgres-url='': url for postgresql
     --prometheus-namespace='': namespace with installed prometheus for autoscaler
+    --psql-12-image='centos/postgresql-12-centos7': The database old container image
     --pv-pool-default-storage-class='': The default storage class name for BackingStores of type pv-pool
     --s3-load-balancer-source-subnets=[]: The source subnets for the S3 service load balancer
     --show-secrets=false: Show the secrets in the status output
     --sts-load-balancer-source-subnets=[]: The source subnets for the STS service load balancer
-    --test-env=false: Install the system with test env minimal resource
+    --test-env=false: Install the system with test env minimal resources
 ```
 (taken from branch 5.16)