Syncing latest changes from master for noobaa-operator #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version to 5.16.0
Signed-off-by: jackyalbo <[email protected]>
Update external-postgres.md - 'c' should be the correct one
Signed-off-by: shirady <[email protected]>
Doc | Add a Case in the Guide Troubleshoot AWS STS Cluster
Signed-off-by: shirady <[email protected]>
Doc | Update Readme Flags
Signed-off-by: shirady <[email protected]>
Update AWS Regions with New Region
…nts (noobaa#1304) Signed-off-by: Ben <[email protected]>
Remove the certificate fix just for GCP as it was causing reflection errors (See noobaa#1312 for more info). Signed-off-by: Ben <[email protected]>
Signed-off-by: jackyalbo <[email protected]>
Adding denyHTTP option to NooBaa CR
Signed-off-by: jackyalbo <[email protected]>
[DB Upgrade] Fixing returned status and adding prints
Bump dependencies Signed-off-by: liranmauda <[email protected]>
Bump dependencies
Updating go lang version to v1.21 controller-gen to v0.14.0 deepcopy-gen to v0.29.3 Signed-off-by: Vinayakswami Hariharmath <[email protected]>
update go version to v1.21
Adding a sidecar container which will run rsyslod and logrotate It will also be running a log segreagate script. Signed-off-by: Ashish Pandey <[email protected]>
bucket_logging: Bucket log processing in side car container
Signed-off-by: Ben <[email protected]>
This patch provides the support for azure keyvault. We are using "libopenstorage/secrets" as the wrapper package to integrate with different kms and package provides the abstraction over several kms. It also provides the integraton support for azure and helps communication with azure key vault. We are required to provide the definition for house keeping calls registered calls with libopenstorage/secrets. "libopenstorage/secrets" does the creation of client handle based on the details provided in configmap. The certificate details present in the secret are preserved inside a temp file and used to establish the connection with azure key vault as of now. Below are the connection details that are going to be populated on Noobaa CR by `noobaa_system_reconciler` at ocs side and this is the ocs code where connectiondetails on Noobaa CR are built: https://github.com/red-hat-storage/ocs-operator/blob/2d082fc4c1ac4cec961406053cece448f4b07684/controllers/storagecluster/noobaa_system_reconciler.go#L249 ex: configmap data: ``` data: AZURE_CERT_SECRET_NAME: azure-ocs-ffwc9o1j AZURE_CLIENT_ID: az-client-id1 AZURE_TENANT_ID: az-tenant-id1 AZURE_VAULT_URL: az-valut-url1 KMS_PROVIDER: azure-kv KMS_SERVICE_NAME: kms-conn-azure1 ``` Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Azure kms handling for noobaa
Nikhil-Ladha
approved these changes
Apr 2, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team, Nikhil-Ladha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from master branch