Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roblox extension #17934

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+16 −10
Open

Update roblox extension #17934

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ade7bd2
Update roblox extension
iamEvanYT Jan 23, 2025
451d40c
Update roblox extension
iamEvanYT Jan 23, 2025
2d61e90
Update package-lock.json
iamEvanYT Jan 23, 2025
be7923d
chore: update changelog again
iamEvanYT Jan 23, 2025
4a508c1
improve command
iamEvanYT Jan 23, 2025
91036c3
fix: map bug
iamEvanYT Mar 17, 2025
b46d207
feat: lint, bump dependencies & add changelog
iamEvanYT Mar 17, 2025
b1078f9
Merge branch 'main' into ext/roblox
iamEvanYT Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions/roblox/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Roblox Changelog

## [Bug Fixes] - 2025-03-17

- fix: Fixed some errors and improved the code.
- chore: updated dependencies

## [Show Image Command] - 2024-11-22

- feat: New command to view an image from Roblox using its Image ID.
12 changes: 6 additions & 6 deletions extensions/roblox/package.json
View file
Original file line number Diff line number Diff line change
@@ -141,17 +141,17 @@
],
"preferences": [],
"dependencies": {
"@raycast/api": "^1.85.2",
"@raycast/utils": "^1.17.0",
"@raycast/api": "^1.93.2",
"@raycast/utils": "^1.19.1",
"cross-fetch": "^4.1.0"
},
"devDependencies": {
"@raycast/eslint-config": "^1.0.11",
"@types/node": "20.8.10",
"@types/node": "^22.13.10",
"@types/react": "18.3.3",
"eslint": "^8.57.0",
"prettier": "^3.3.3",
"typescript": "^5.4.5"
"eslint": "^8.57.1",
"prettier": "^3.5.3",
"typescript": "^5.8.2"
},
"scripts": {
"build": "ray build",
4 changes: 2 additions & 2 deletions extensions/roblox/src/components/game-page.tsx
View file
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ export function PlacesPage({ universeId }: RenderPlacesPageProps) {

return (
<List>
{placesData.data.map((place) => {
{placesData?.data?.map((place) => {
const { id: placeId } = place;

const placeUrl = generateGamePageLink(placeId);
@@ -157,7 +157,7 @@ export function GamePage({ universeId, options }: RenderGamePageProps) {

const detailMarkdown = `
# ${name}
${thumbnailUrls.map((thumbnailUrl) => `![](${thumbnailUrl}?raycast-height=450)`).join("\n\n")}
${thumbnailUrls?.map((thumbnailUrl) => `![](${thumbnailUrl}?raycast-height=450)`).join("\n\n")}
`;

const updatedDateText = getUpdatedText(updated);
5 changes: 3 additions & 2 deletions extensions/roblox/src/search-games.tsx
View file
Original file line number Diff line number Diff line change
@@ -85,8 +85,9 @@ export default (props: LaunchProps<{ arguments: Arguments.SearchGames }>) => {
}, []);

const gameIds = useMemo(() => {
return games.map((game) => game.universeId);
return games?.map((game) => game.universeId);
}, [games]);

const { data: thumbnails, isLoading: thumbnailsLoading } = useBatchGameThumbnails(gameIds);

const isLoading = searchResultsLoading || thumbnailsLoading;
@@ -101,7 +102,7 @@ export default (props: LaunchProps<{ arguments: Arguments.SearchGames }>) => {
filtering={false}
isShowingDetail
>
{games.map((game) => {
{games?.map((game) => {
const gameThumbnails = thumbnails[game.universeId];
return (
<GamesListItem