Update roblox extension #17934

iamEvanYT · 2025-03-17T16:30:21Z

Description

fix: Fixed some errors and improved the code.
chore: updated dependencies
I don't know why it said I added a command, but that command was already added in Update roblox extension #16576

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- Merge branch \'contributions/merge-1737665820630\' - feat: add \'Show Image\' command

- feat: enhance image display with ID in markdown - Update Changelog

raycastbot · 2025-03-17T16:30:39Z

Thank you for the update! 🎉

Due to our current reduced availability, the initial review may take up to 10-15 business days

greptile-apps

PR Summary

This PR adds a new command to view Roblox images using their Image ID, with caching and image type validation functionality.

CHANGELOG.md entries use hardcoded dates (2024-11-22) instead of required {PR_MERGE_DATE} template string
External API usage (toilettowerdefense.com) in show-image.tsx needs proper error handling and documentation
Image fetching in show-image.tsx should be wrapped in try-catch and include memory management for large images
Optional chaining in search-games.tsx is unnecessary since games array is initialized as empty by default
Metadata folder missing for view commands in new extension (show-image)

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{7 file(s) reviewed, 9 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-03-17T16:31:46Z

extensions/roblox/CHANGELOG.md

+- feat: New command to view an image from Roblox using its Image ID.
+
+## [Initial Version] - 2024-11-22


syntax: The date should be {PR_MERGE_DATE} instead of a hardcoded date

Suggested change

## [Initial Version] - 2024-11-22

## [Initial Version] - {PR_MERGE_DATE}

greptile-apps · 2025-03-17T16:32:40Z

extensions/roblox/package.json

+    {
+      "name": "show-image",
+      "title": "Show Image",
+      "description": "Show a Roblox Image!",


style: Add 'subtitle: "Roblox"' to provide context for the command

greptile-apps · 2025-03-17T16:32:40Z

extensions/roblox/src/modules/image-lib.ts

+};
+
+type ImageCache = {
+  [assetId: string]: ImageData;


logic: assetId should be number type in ImageCache index signature since grabImage takes a number parameter

Suggested change

[assetId: string]: ImageData;

[assetId: number]: ImageData;

greptile-apps · 2025-03-17T16:32:40Z

extensions/roblox/package.json

+        {
+          "name": "id",
+          "placeholder": "Image ID",
+          "type": "text",


style: Consider making 'id' required since the command won't work without it

Suggested change

"type": "text",

"type": "text",

"required": true

greptile-apps · 2025-03-17T16:32:41Z

extensions/roblox/src/modules/image-lib.ts

+  } catch (error) {
+    return null;
+  }


style: silently returning null masks all errors - consider using showFailureToast from @raycast/utils to show error messages

greptile-apps · 2025-03-17T16:32:41Z

extensions/roblox/package.json

@@ -104,7 +104,7 @@
    {
      "name": "playing-game",
      "title": "Get Playing Game",


style: Title should be 'Show Playing Game' to follow verb-noun format

greptile-apps · 2025-03-17T16:32:41Z

extensions/roblox/src/modules/image-lib.ts

+
+  try {
+    // Fetch the image if not in cache.
+    const response = await fetch(`https://assetdelivery.roblox.com/v1/asset/?ID=${assetId}`);


style: URL string should be defined as a constant at the module level

greptile-apps · 2025-03-17T16:32:42Z

extensions/roblox/src/modules/image-lib.ts

+
+function getImageContentType(buffer: Buffer) {
+  const magicNumbers = {
+    "image/jpg": ["ffd8ff", "ffd8ffe0", "ffd8ffe1"], // Added variations for JPEG


logic: image/jpg is non-standard, should be image/jpeg

Suggested change

"image/jpg": ["ffd8ff", "ffd8ffe0", "ffd8ffe1"], // Added variations for JPEG

"image/jpeg": ["ffd8ff", "ffd8ffe0", "ffd8ffe1"], // Added variations for JPEG

socket-security · 2025-03-17T16:55:08Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@raycast/[email protected]	environment, filesystem	`+2`	459 kB	thomlom
npm/[email protected]	network	`0`	93.3 kB	lquixada
npm/[email protected] ➜ 8.57.1	filesystem Transitive: shell	`+6`	4.53 MB	eslintbot
npm/[email protected]	None	`0`	22.4 MB	typescript-bot

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

pernielsentikaer · 2025-03-18T13:40:56Z

Do you need help with the CI error mentioned here

iamEvanYT · 2025-03-19T07:52:25Z

It's actually a error with the CLI that stopped me from pushing. Didn't have time to try that again yet.

pernielsentikaer · 2025-03-19T08:14:29Z

If everything it going crazy, then you can also do that directly from GitHub by hitting .(dot) in this PR

iamEvanYT added 6 commits January 23, 2025 20:57

Update roblox extension

Loading
Loading status checks…

ade7bd2

- Merge branch \'contributions/merge-1737665820630\' - feat: add \'Show Image\' command

Update roblox extension

Loading
Loading status checks…

451d40c

- feat: enhance image display with ID in markdown - Update Changelog

Update package-lock.json

Loading
Loading status checks…

2d61e90

chore: update changelog again

Loading
Loading status checks…

be7923d

improve command

Loading
Loading status checks…

4a508c1

fix: map bug

Loading
Loading status checks…

91036c3

raycastbot added extension fix / improvement extension: roblox labels Mar 17, 2025

raycastbot added the OP is author label Mar 17, 2025

greptile-apps bot reviewed Mar 17, 2025

View reviewed changes

iamEvanYT added 2 commits March 17, 2025 16:44

feat: lint, bump dependencies & add changelog

Loading
Loading status checks…

b46d207

Merge branch 'main' into ext/roblox

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

b1078f9

Gerro84 approved these changes Mar 18, 2025

View reviewed changes

raycast deleted a comment from greptile-apps bot Mar 18, 2025

pernielsentikaer self-assigned this Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update roblox extension #17934

Update roblox extension #17934

iamEvanYT commented Mar 17, 2025 •

edited

Loading

raycastbot commented Mar 17, 2025

greptile-apps bot left a comment

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

greptile-apps bot Mar 17, 2025

socket-security bot commented Mar 17, 2025

pernielsentikaer commented Mar 18, 2025

iamEvanYT commented Mar 19, 2025

pernielsentikaer commented Mar 19, 2025

		- feat: New command to view an image from Roblox using its Image ID.

		## [Initial Version] - 2024-11-22

	## [Initial Version] - 2024-11-22
	## [Initial Version] - {PR_MERGE_DATE}

	"image/jpg": ["ffd8ff", "ffd8ffe0", "ffd8ffe1"], // Added variations for JPEG
	"image/jpeg": ["ffd8ff", "ffd8ffe0", "ffd8ffe1"], // Added variations for JPEG

Update roblox extension #17934

Are you sure you want to change the base?

Update roblox extension #17934

Conversation

iamEvanYT commented Mar 17, 2025 • edited Loading

Description

Screencast

Checklist

raycastbot commented Mar 17, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 17, 2025

Choose a reason for hiding this comment

socket-security bot commented Mar 17, 2025

pernielsentikaer commented Mar 18, 2025

iamEvanYT commented Mar 19, 2025

pernielsentikaer commented Mar 19, 2025

iamEvanYT commented Mar 17, 2025 •

edited

Loading