Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'tomli' dependency #228

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

jameslamb
Copy link
Member

Proposes removing the build-time dependency on tomli for wheels and conda packages.

It doesn't appear to be used anywhere here.

git grep tomli

Notes for Reviewers

I originally noticed something similar in ucx-py (rapidsai/ucx-py#1042), then went searching for similar cases across RAPIDS.

That dependency was added for distributed-ucxx back in #60. I'm not sure why, but I suspect it was related to the use of versioneer in this project at the time. Reference: python-versioneer/python-versioneer#338 (comment)

This project doesn't use versioneer any more (#114). I strongly suspect that the dependency on tomli can be removed.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 6, 2024
@jameslamb jameslamb requested review from a team as code owners May 6, 2024 18:38
@wence-
Copy link
Contributor

wence- commented May 7, 2024

Hmm, I think you are right, and that the toml parsing that must be required by the build backend just installs tomli in the build env for python < 3.11

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems probable.

@jameslamb
Copy link
Member Author

Yep, I think so! scikit-build-core will pull in tomli if it needs it: https://github.com/scikit-build/scikit-build-core/blob/f6ed5a28fc85e621b03d984011d17def888ee0db/pyproject.toml#L41

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 42a1f89 into rapidsai:branch-0.38 May 7, 2024
56 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@jameslamb jameslamb deleted the remove-tomli branch May 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants