Skip to content

Commit 42a1f89

Browse files
authoredMay 7, 2024··
remove 'tomli' dependency (#228)
Proposes removing the build-time dependency on `tomli` for wheels and conda packages. It doesn't appear to be used anywhere here. ```shell git grep tomli ``` ## Notes for Reviewers I originally noticed something similar in `ucx-py` (rapidsai/ucx-py#1042), then went searching for similar cases across RAPIDS. That dependency was added for `distributed-ucxx` back in #60. I'm not sure why, but I suspect it was related to the use of `versioneer` in this project at the time. Reference: python-versioneer/python-versioneer#338 (comment) This project doesn't use `versioneer` any more (#114). I strongly suspect that the dependency on `tomli` can be removed. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Lawrence Mitchell (https://github.com/wence-) - https://github.com/jakirkham - Ray Douglass (https://github.com/raydouglass) URL: #228
1 parent b117fda commit 42a1f89

File tree

5 files changed

+0
-5
lines changed

5 files changed

+0
-5
lines changed
 

‎conda/environments/all_cuda-118_arch-x86_64.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,5 @@ dependencies:
4040
- scikit-build-core>=0.7.0
4141
- setuptools>=64.0.0
4242
- spdlog>=1.12.0,<1.13
43-
- tomli
4443
- ucx>=1.15.0
4544
name: all_cuda-118_arch-x86_64

‎conda/environments/all_cuda-122_arch-x86_64.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,5 @@ dependencies:
4040
- scikit-build-core>=0.7.0
4141
- setuptools>=64.0.0
4242
- spdlog>=1.12.0,<1.13
43-
- tomli
4443
- ucx>=1.15.0
4544
name: all_cuda-122_arch-x86_64

‎conda/recipes/ucxx/meta.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ outputs:
275275
- pip
276276
- setuptools
277277
- wheel
278-
- tomli
279278
run:
280279
- python * *_cpython
281280
- rapids-dask-dependency =24.06

‎dependencies.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ dependencies:
144144
- output_types: [conda, requirements, pyproject]
145145
packages:
146146
- setuptools>=64.0.0
147-
- tomli
148147
checks:
149148
common:
150149
- output_types: [conda, requirements]

‎python/distributed-ucxx/pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
build-backend = "setuptools.build_meta"
33
requires = [
44
"setuptools>=64.0.0",
5-
"tomli",
65
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
76

87
[project]

0 commit comments

Comments
 (0)
Please sign in to comment.