Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag for plugins supporting Qt6 #8982

Closed
wants to merge 1 commit into from
Closed

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Mar 22, 2024

I think I read something about this few weeks ago...
@rduivenvoorde @nyalldawson @troopa81 Is this OK?

@DelazJ DelazJ added PyQGIS Cookbook Plugins Core plugins, enhancement to handle community plugins labels Mar 22, 2024
@DelazJ DelazJ changed the title Add tags for plugins supporting Qt6 Add tag for plugins supporting Qt6 Mar 22, 2024
@rduivenvoorde
Copy link
Contributor

Yep looks good to me. I see in my plugin I use 'yes' instead of 'True', apparently both are valid?

@troopa81
Copy link
Contributor

Looks good to me to!

@DelazJ
Copy link
Collaborator Author

DelazJ commented Mar 25, 2024

I see in my plugin I use 'yes' instead of 'True', apparently both are valid?

No strong idea 😄 but I think there used to be this double usage of boolean in the plugin metadata file. No idea how I could verify this, but as most of the boolean tags in the sample here were using True/False I opted for consistency.

@rduivenvoorde
Copy link
Contributor

FYI: I created an issue to add this tag to the plugins.xml: qgis/QGIS-Django#373

@elpaso
Copy link
Contributor

elpaso commented Mar 25, 2024

@rduivenvoorde wouldn't be more future proof if we used minQtVersion/maxQtVersion (both defaulting to 5 for now) ?

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 11, 2024

So, verdict: supportsQt6 or minQtVersion/maxQtVersion?

@rduivenvoorde
Copy link
Contributor

@DelazJ I like @elpaso 's proposal, though it would probably need some small changes in core then.
@nyalldawson do you have a strong opinion on this?

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 24, 2024

OK let's then close and wait for the min/max options. Might be a worth an issue report in code repo?

@DelazJ DelazJ closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugins Core plugins, enhancement to handle community plugins PyQGIS Cookbook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants