Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt6 support, show min_qt_version and max_qt_version int the XML #386

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Apr 22, 2024

This is the proposed change for #373 according to the (ongoing) discussion at qgis/QGIS-Documentation#8982

Changes summary

  • Add new keys in metadata: minQtVersion and maxQtVersion (both defaulting to 5 for now)
  • Show the new keys in the plugin details and the XML list

image

image

@DelazJ
Copy link
Contributor

DelazJ commented Apr 25, 2024

Thanks @Xpirix for this update.
Given that we already have qgisMinimumVersion and qgisMaximumVersion in the metadata file, would it make sense to keep that structure and instead have qtMinimumVersion and qtMaximumVersion?
@elpaso @rduivenvoorde

@DelazJ
Copy link
Contributor

DelazJ commented Apr 25, 2024

I have no idea if this is a situation that may happen irl (or if it is desirable) but would that allow someone to constrain his plugins to work for specific qt versions, e.g. min=5.13 and/or max=6.6 because of incompatible changes in Qt's other versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants