Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleFSDP to leaf node #2835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SimpleFSDP to leaf node #2835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions torchrec/distributed/train_pipeline/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

if not torch._running_with_deploy():
from torch.distributed._composable.fsdp.fully_shard import FSDPModule as FSDP2
from torch.distributed.fb.simple_fsdp import SimpleFSDPModule as SimpleFSDP
else:

class FSDP2:
Expand Down Expand Up @@ -743,6 +744,7 @@ def is_leaf_module(self, m: torch.nn.Module, module_qualified_name: str) -> bool
or module_qualified_name in self._leaf_modules
or isinstance(m, FSDP)
or isinstance(m, FSDP2)
or isinstance(m, SimpleFSDP)
):
return True
return super().is_leaf_module(m, module_qualified_name)
Expand Down
Loading