Add SimpleFSDP to leaf node #2835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71450848 |
Microve
added a commit
to Microve/torchrec
that referenced
this pull request
Mar 19, 2025
Summary: Torchrec should not trace into SimpleFSDP which will cause failures. We thus added it to the leaf node Differential Revision: D71450848
Microve
force-pushed
the
export-D71450848
branch
from
7c0a68a to
13ba03e
Compare
Summary: Pull Request resolved: pytorch#2835 Torchrec should not trace into SimpleFSDP which will cause failures. We thus added it to the leaf node Differential Revision: D71450848
|
This pull request was exported from Phabricator. Differential Revision: D71450848 |
Microve
force-pushed
the
export-D71450848
branch
from
13ba03e to
d2828fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Torchrec should not trace into SimpleFSDP which will cause failures. We thus added it to the leaf node
Differential Revision: D71450848