Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108295: Fix crashes with TypeVar weakrefs #108517

Merged
merged 1 commit into from
Aug 27, 2023
Merged

gh-108295: Fix crashes with TypeVar weakrefs #108517

merged 1 commit into from
Aug 27, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Aug 26, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 26, 2023
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 bug and security fixes label Aug 26, 2023
@AlexWaygood AlexWaygood removed their request for review August 26, 2023 15:42
gvanrossum
gvanrossum approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m no expert on weak refs but LGTM.

@JelleZijlstra JelleZijlstra merged commit 482fad7 into python:main Aug 27, 2023
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the tvweak branch August 27, 2023 00:13
@bedevere-bot
Copy link

GH-108527 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Aug 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2023
@JelleZijlstra @miss-islington
pythongh-108295: Fix crashes with TypeVar weakrefs (pythonGH-108517)
fd4b97f 
(cherry picked from commit 482fad7)

Co-authored-by: Jelle Zijlstra <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 27, 2023
@miss-islington @JelleZijlstra
[3.12] gh-108295: Fix crashes with TypeVar weakrefs (GH-108517) (#108527
09877a1 
)

gh-108295: Fix crashes with TypeVar weakrefs (GH-108517)
(cherry picked from commit 482fad7)

Co-authored-by: Jelle Zijlstra <[email protected]>
@AlexWaygood AlexWaygood mentioned this pull request Oct 1, 2023
Closed
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Oct 1, 2023
@JelleZijlstra
pythongh-110178: Use fewer weakrefs
7b599ab 
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 1, 2023
Merged
JelleZijlstra added a commit that referenced this pull request Oct 2, 2023
@JelleZijlstra
gh-110178: Use fewer weakrefs in test_typing.py (#110194)
732ad44 
Confirmed that without the C changes from #108517, this test still segfaults with only 10 weakrefs.
@miss-islington miss-islington mentioned this pull request Oct 2, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@JelleZijlstra @miss-islington
pythongh-110178: Use fewer weakrefs in test_typing.py (pythonGH-110194)
6c82b0b 
Confirmed that without the C changes from pythonGH-108517, this test still segfaults with only 10 weakrefs.
(cherry picked from commit 732ad44)

Co-authored-by: Jelle Zijlstra <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @JelleZijlstra
[3.12] gh-110178: Use fewer weakrefs in test_typing.py (GH-110194) (#…
46e6957 
…110224)

gh-110178: Use fewer weakrefs in test_typing.py (GH-110194)

Confirmed that without the C changes from GH-108517, this test still segfaults with only 10 weakrefs.
(cherry picked from commit 732ad44)

Co-authored-by: Jelle Zijlstra <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@JelleZijlstra @Glyphack
pythongh-110178: Use fewer weakrefs in test_typing.py (python#110194)
7bc7e2b 
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
@JelleZijlstra JelleZijlstra restored the tvweak branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JelleZijlstra @miss-islington @bedevere-bot @gvanrossum @Fidget-Spinner @kumaraditya303