-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_typing
: test_many_weakrefs
takes many seconds
#110178
Labels
Comments
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this issue
Oct 1, 2023
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
JelleZijlstra
added a commit
that referenced
this issue
Oct 2, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 2, 2023
Confirmed that without the C changes from pythonGH-108517, this test still segfaults with only 10 weakrefs. (cherry picked from commit 732ad44) Co-authored-by: Jelle Zijlstra <[email protected]>
Thanks Jelle! |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug report
Bug description:
TypeVarTests.test_many_weakrefs
intest_typing
takes far longer than any other test intest_typing
if you're using a debug build of CPython, slowing downtest_typing
considerably:The test was added in #108517, as a regression test for #108295.
The slowdown caused by this test is much less pronounced if you use a PGO-optimised non-debug build, but the test still takes much longer than any other test in
test_typing
on my machine:The test currently attempts to create 100,000 TypeVar weakrefs, 100,000 ParamSpec weakrefs and 100,000 TypeVarTuple weakrefs:
cpython/Lib/test/test_typing.py
Lines 547 to 555 in 038c356
@JelleZijlstra, reckon we could maybe make that number a little smaller? :)
CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Linked PRs
The text was updated successfully, but these errors were encountered: