Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CDN feature #21

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Use CDN feature #21

merged 4 commits into from
Mar 24, 2025

Conversation

ArtyomVancyan
Copy link
Member

Motivation:

In the scope of #20, this PR implements a feature suggested by @maiksprenger. The idea was to use the CDN URL directly without creating a local copy as a static file.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@ArtyomVancyan ArtyomVancyan merged commit 8fed55d into pysnippet:master Mar 24, 2025
22 checks passed
@ArtyomVancyan ArtyomVancyan deleted the use_cdn_feature branch March 24, 2025 12:00
maiksprenger added a commit to maiksprenger/django-mermaid that referenced this pull request Mar 25, 2025
@maiksprenger
Only download mermaid.js if MERMAID_USE_CDN is False
1c098f2 
This is a follow-up to
pysnippet#20

pysnippet#21 added a CDN feature,
which means the added script tag will point to the CDN version of
mermaid.js. But it still tries to download a copy to the package's
static directory in AppConfig.ready.

Because this isn't necessary in CDN mode and causes us a PermissionError
during deployment, I'm proposing we only download in non-CDN mode.
maiksprenger added a commit to maiksprenger/django-mermaid that referenced this pull request Mar 25, 2025
@maiksprenger
Only download mermaid.js if MERMAID_USE_CDN is False
3f08925 
This is a follow-up to
pysnippet#20

pysnippet#21 added a CDN feature,
which means the added script tag will point to the CDN version of
mermaid.js. But it still tries to download a copy to the package's
static directory in AppConfig.ready.

Because this isn't necessary in CDN mode and causes us a PermissionError
during deployment, I'm proposing we only download in non-CDN mode.
@maiksprenger maiksprenger mentioned this pull request Mar 25, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArtyomVancyan