Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is a follow-up to #20
#21 added a CDN feature, which means the added script tag will point to the CDN version of mermaid.js. Thank you again for adding that!
But
django-mermaid
still tries to download a copy to the package's static directory in AppConfig.ready. Because this isn't necessary in CDN mode and causes us aPermissionError
during deployment, I'm proposing we only download in non-CDN mode.All Submissions:
Changes to Core Features: