Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop implicitly emitting deprecated process runtime metrics #932

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Mar 14, 2025

Builds on #930

These are breaking changes that should be included in the next major release.

Copy link
Contributor

hyperlint-ai bot commented Mar 14, 2025

PR Change Summary

Updated system metrics instrumentation to stop emitting deprecated process runtime metrics and simplified metric naming.

  • Replaced deprecated metric 'process.runtime.cpu.utilization' with 'process.cpu.utilization'.
  • Removed deprecated metrics related to process runtime memory and CPU time.
  • Clarified documentation regarding the metrics and their configurations.

Modified Files

  • docs/integrations/system-metrics.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2025

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 65b4a43
Status: ✅  Deploy successful!
Preview URL: https://61f4fe22.logfire-docs.pages.dev
Branch Preview URL: https://alex-system-metrics-breaking.logfire-docs.pages.dev

View logs

@alexmojaki
Copy link
Contributor Author

I'll resolve merge conflicts after the base gets merged, or maybe not at all until we want to make a major release.

Base automatically changed from alex/system-metrics-update to main March 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant