-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document deprecated process runtime metrics #930
Conversation
PR Change SummaryDocumented the deprecation of certain process runtime metrics and introduced new metrics in the system metrics documentation.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
Deploying logfire-docs with
|
Latest commit: |
8f450cc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://14e4230d.logfire-docs.pages.dev |
Branch Preview URL: | https://alex-system-metrics-update.logfire-docs.pages.dev |
…ire into alex/system-metrics-update
Discussion in https://pydantic.slack.com/archives/C0813FX362E/p1741867835353059
In open-telemetry/opentelemetry-python-contrib#3250, these:
were deprecated in favour of:
The new metrics are already being emitted alongside the old ones when using
logfire.instrument_system_metrics(base='full')
, we just note this in the docs and update the tests.The default
logfire.instrument_system_metrics()
hasn't changed and isn't yet.Both should be updated next time we make a major release: #932
Also added a new metric
process.cpu.core_utilization
which is equivalent toprocess.runtime.cpu.utilization
in value.process.cpu.utilization
isn't equivalent because it's divided by the number of cores which makes it less useful IMO.Update to dashboard template: https://github.com/pydantic/platform/pull/8435