Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Townsends snow model references #2384

Merged
merged 8 commits into from
Feb 12, 2025
Merged

Updating Townsends snow model references #2384

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ca58a5
Updating Townsends snow model references
ayushjariyal Feb 9, 2025
47c9d18
Applying reviews
ayushjariyal Feb 9, 2025
57bca5e
Adding a note to the whatsnew file for v0.11.3
ayushjariyal Feb 10, 2025
95e7b08
Applying review
ayushjariyal Feb 10, 2025
b80892b
Add myself as contributor and apply reviews
ayushjariyal Feb 10, 2025
7d699c8
Fix the line length issue
ayushjariyal Feb 10, 2025
1e845f0
Adding actual title of the poster
ayushjariyal Feb 11, 2025
953653b
correct doi syntax
ayushjariyal Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew/v0.11.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Documentation
~~~~~~~~~~~~~
* Fix Procedural and Object Oriented simulation examples having slightly different results, in :ref:`introtutorial`. (:issue:`2366`, :pull:`2367`)
* Restructure the user guide with subsections (:issue:`2302`, :pull:`2310`)
* Add references for :py:func:`pvlib.snow.loss_townsend`. (:issue:`2383`, :pull:`2384`)

Testing
~~~~~~~
Expand Down
11 changes: 8 additions & 3 deletions pvlib/snow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,16 +278,21 @@
axis to the module edge.

The parameter `string_factor` is an enhancement added to the model after
publication of [1]_ per private communication with the model's author. The
definition for snow events documented above is also based on private
communication with the model's author.
publication of [1]_, as described in [2]_.
The definition for snow events documented above is based on [3]_.

References
----------
.. [1] Townsend, Tim & Powers, Loren. (2011). Photovoltaics and snow: An
update from two winters of measurements in the SIERRA. 37th IEEE
Photovoltaic Specialists Conference, Seattle, WA, USA.
:doi:`10.1109/PVSC.2011.6186627`
.. [2] Townsend, T. and Previtali, J. (2023). A Fresh Dusting: Current Uses of the Townsend

Check failure on line 290 in pvlib/snow.py

View workflow job for this annotation

GitHub Actions / flake8-linter 

E501 line too long (95 > 79 characters)
Snow Model. In "Photovoltaic Reliability Workshop (PVRW) 2023 Proceedings: Posters.",

Check failure on line 291 in pvlib/snow.py

View workflow job for this annotation

GitHub Actions / flake8-linter 

E501 line too long (93 > 79 characters)
ed. Silverman, T. J. Dec. 2023. NREL/CP-5900-87918.
cwhanse marked this conversation as resolved.
Show resolved Hide resolved
Available at: https://www.nrel.gov/docs/fy25osti/90585.pdf
.. [3] Townsend, T. (2025). Snow Events Definition.
:doi:`10.13140/RG.2.2.14299.68647`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use the actual title of the poster and also mention that it was presented in SPI conference in 2013 (see info in the image below)

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - I overlooked the "SPI 2013" conference label. Reference text should be

[3] Townsend, T. (2013). Predicting PV Energy Loss Caused by Snow. Solar Power International, Chicago IL. :doi:10.13140/RG.2.2.14299.68647

'''

# unit conversions from cm and m to in, from C to K, and from % to fraction
Expand Down
Loading