Updating Townsends snow model references #2384
Conversation
ayushjariyal
commented
Feb 9, 2025
ayushjariyal
commented
- Closes loss_townsend: Update Townsend Snow Model References #2383
There was a problem hiding this comment.
@ayushjariyal you will need to fix the line length and indentation in reference [2]
Please add a note to the whatsnew file for v0.11.3
pvlib/snow.py
Outdated
| .. [2] Townsend, T. (2025). Snow Loss Model Enhancements. | ||
| Available at: https://www.nrel.gov/docs/fy25osti/90585.pdf |
There was a problem hiding this comment.
| .. [2] Townsend, T. (2025). Snow Loss Model Enhancements. | |
| Available at: https://www.nrel.gov/docs/fy25osti/90585.pdf | |
| .. [2] Townsend, T. and Previtali, J. (2023). A Fresh Dusting: Current Uses of the Townsend | |
| Snow Model. In "Photovoltaic Reliability Workshop (PVRW) 2023 Proceedings: Posters.", | |
| ed. Silverman, T. J. Dec. 2023. NREL/CP-5900-87918. | |
| Available at: https://www.nrel.gov/docs/fy25osti/90585.pdf |
There was a problem hiding this comment.
You will need to adjust the line lengths in reference [2] to 79 characters or less.
| * Fix fornatting in the References section to ensure proper line length and indentation, | ||
| specifically for reference [2] in the documentation.(:issue:`2383`, :pull:`2384`) |
There was a problem hiding this comment.
| * Fix fornatting in the References section to ensure proper line length and indentation, | |
| specifically for reference [2] in the documentation.(:issue:`2383`, :pull:`2384`) | |
| * Add references for :py:func:`pvlib.snow.loss_townsend`. (:issue:`2383`, :pull:`2384`) |
There was a problem hiding this comment.
If you agree we'd like you to add your GH and name to the Contributor's section.
There was a problem hiding this comment.
Thank you, @cwhanse ! I’d be honored to add my name and GH to the Contributors' section. I really appreciate the opportunity to contribute to this project!
pvlib/snow.py
Outdated
| .. [2] Townsend, T. and Previtali, J. (2023). A Fresh Dusting: Current Uses of the Townsend | ||
| Snow Model. In "Photovoltaic Reliability Workshop (PVRW) 2023 Proceedings: Posters.", | ||
| ed. Silverman, T. J. Dec. 2023. NREL/CP-5900-87918. |
There was a problem hiding this comment.
| .. [2] Townsend, T. and Previtali, J. (2023). A Fresh Dusting: Current Uses of the Townsend | |
| Snow Model. In "Photovoltaic Reliability Workshop (PVRW) 2023 Proceedings: Posters.", | |
| ed. Silverman, T. J. Dec. 2023. NREL/CP-5900-87918. | |
| .. [2] Townsend, T. and Previtali, J. (2023). A Fresh Dusting: Current Uses of the | |
| Townsend Snow Model. In "Photovoltaic Reliability Workshop (PVRW) 2023 | |
| Proceedings: Posters.", ed. Silverman, T. J. Dec. 2023. NREL/CP-5900-87918. |
|
@ayushjariyal can you fix the line length issues in your editor? I'm having difficulty suggesting corrections here. |
ayushjariyal
force-pushed
the
issue_2383
branch
from
af253e3 to
7d699c8
Compare
|
@cwhanse I’m having trouble understanding why the tests are failing.
Could you please help clarify the issue? |
You can ignore those failures. They are unrelated to the changes you made and they are happening in other PRs. |
|
Thank you for the clarification! |
pvlib/snow.py
Outdated
| .. [3] Townsend, T. (2025). Snow Events Definition. | ||
| :doi:`10.13140/RG.2.2.14299.68647` |
There was a problem hiding this comment.
I suggest we use the actual title of the poster and also mention that it was presented in SPI conference in 2013 (see info in the image below)
There was a problem hiding this comment.
I agree - I overlooked the "SPI 2013" conference label. Reference text should be
[3] Townsend, T. (2013). Predicting PV Energy Loss Caused by Snow. Solar Power International, Chicago IL. :doi:10.13140/RG.2.2.14299.68647
