Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-systemd-exporter] Add values for default args #4847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Open

[prometheus-systemd-exporter] Add values for default args #4847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
290b846
[prometheus-systemd-exporter] Add values for default args
glennpratt Sep 10, 2024
b427193
Merge branch 'main' into systemd-exporter-args
zanhsieh Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-systemd-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: prometheus-systemd-exporter
description: A Helm chart for prometheus systemd-exporter
type: application
version: 0.3.0
version: 0.4.0
appVersion: "0.6.0"
home: https://github.com/prometheus-community/systemd_exporter
sources:
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-systemd-exporter/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ spec:
image: {{ include "prometheus-systemd-exporter.image" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- --log.level=info
- --systemd.collector.unit-include=kubelet.service|docker.service
- --log.level={{ .Values.logLevel }}
- --systemd.collector.unit-include={{ .Values.unitIncludeRegex }}
{{- with .Values.extraArgs }}
{{- toYaml . | nindent 10 }}
{{- end }}
Expand Down
8 changes: 7 additions & 1 deletion charts/prometheus-systemd-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ env: {}
## env:
## VARIABLE: value

# extraArgs allows to pass command line arguments, as described on https://github.com/prometheus-community/systemd_exporter?tab=readme-ov-file#configuration
# Log level for systemd_exporter
logLevel: info
Copy link
Contributor

@maxime1907 maxime1907 Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put everything under config: so that it nicely separates concerns


# Include systemd units matched with RE2, see https://github.com/prometheus-community/systemd_exporter?tab=readme-ov-file#configuration
unitIncludeRegex: kubelet.service|docker.service

# extraArgs allows to pass command line arguments, as described on https://github.com/prometheus-community/systemd_exporter?tab=readme-ov-file#systemd-versions
extraArgs: []
# - --systemd.collector.enable-resolved

Expand Down