[prometheus-systemd-exporter] Add values for default args #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Glenn Pratt <[email protected]>
glennpratt
force-pushed
the
systemd-exporter-args
branch
from
4b7644a
to
290b846
Compare
|
For review @capuche2412 @maxime1907 |
maxime1907
reviewed
Sep 12, 2024
| @@ -50,7 +50,13 @@ env: {} | |||
| ## env: | |||
| ## VARIABLE: value | |||
|
|
|||
| # extraArgs allows to pass command line arguments, as described on https://github.com/prometheus-community/systemd_exporter?tab=readme-ov-file#configuration | |||
| # Log level for systemd_exporter | |||
| logLevel: info | |||
There was a problem hiding this comment.
put everything under config: so that it nicely separates concerns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Allows specifying values for default args which cannot be duplicated in extraArgs (fatal error).
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])