Revert changes to OnScreenKeyboardOverlapsGameWindow
on iOS
#6512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnScreenKeyboardOverlapsGameWindow
on iOS when hardware keyboard is attached #6407SDLGameHost
as-is, as I think it's still good for any case of running the game on a 3-in-1 laptop with keyboard detached (assuming windows will slide up a software keyboard on any request of text input).This introduced horrible UX in reality, contrary to what I thought and have seen when I added this. It seems I have not tested this enough back then.
While the on-sceren keyboard hides when a hardware keyboard is connected, it can be brought back, and once it's back, it does not hide again until the user explicitly hides it again.
This introduces very weird / ugly behaviour when combined with a
FocusedTextBox
on osu!, e.g.:ScreenRecording_01-25-2025.23-13-08_1.MP4
(after I brought back the on-screen keyboard, I began tapping on empty spots in the settings overlay, causing the keyboard to slide down, and then slide back up due to the logic of
FocusedTextBox
)