Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to OnScreenKeyboardOverlapsGameWindow on iOS #6512

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

frenzibyte
Copy link
Member

This introduced horrible UX in reality, contrary to what I thought and have seen when I added this. It seems I have not tested this enough back then.

While the on-sceren keyboard hides when a hardware keyboard is connected, it can be brought back, and once it's back, it does not hide again until the user explicitly hides it again.

This introduces very weird / ugly behaviour when combined with a FocusedTextBox on osu!, e.g.:

ScreenRecording_01-25-2025.23-13-08_1.MP4

(after I brought back the on-screen keyboard, I began tapping on empty spots in the settings overlay, causing the keyboard to slide down, and then slide back up due to the logic of FocusedTextBox)

@peppy
Copy link
Member

peppy commented Jan 26, 2025

it can be brought back, and once it's back, it does not hide again until the user explicitly hides it again.

brought back how?

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@peppy peppy merged commit f6c6177 into ppy:master Jan 26, 2025
14 checks passed
@frenzibyte frenzibyte deleted the revert-onscreen-keyboard-ux branch January 26, 2025 06:58
@frenzibyte
Copy link
Member Author

it can be brought back, and once it's back, it does not hide again until the user explicitly hides it again.

brought back how?

CleanShot.2025-01-26.at.02.00.25.mp4

@peppy
Copy link
Member

peppy commented Jan 26, 2025

Not sure this is so bad but ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants