Prototype demonstrating possible px.overlay #2868
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflows colors, changes adds figure titles to legend names to differentiate the source figures in the final plot, includes all annotation-like objects in the final plot.
Argument and logic is there, but not yet tested. It doesn't break the case where px_combine was called with fig1_secondary_y=False.
Cannot yet copy annotation-like things to the final plot as we need to find out which row and column in the subplots they are referring to.
nicholas-esterer
changed the title
to a subplot on a new figure. This will allow us to copy the annotations to a new figure with more axes as part of a px.overlay command. This just needs to be generalized to work with shapes and images but the workings can be seen in proto/px_overlay/map_axis_pair_example.py.
It works but it seems the "start_cell" argument of make_subplots has not been taken into consideration. Also sometimes it adds annotations twice?
look in `proto/px_overlay/README.md` for more information.
gvwilson
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT meant to be merged like this, just showing what such a call might look like.
Also see #2648