Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend variable expansion to consider variables from worker config #6047

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Extend variable expansion to consider variables from worker config #6047

merged 3 commits into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. Improve documentation about variable expansion

    @Martchus
    Martchus committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    328cd58 View commit details
    Browse the repository at this point in the history

  2. Avoid use of contraction in variable precedence documentation

    @Martchus
    Martchus committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e2f0e78 View commit details
    Browse the repository at this point in the history

  3. Extend variable expansion to consider variables from worker config 

    * Allow substituting placeholders that refer to variables that are only
  defined in `workers.ini` for the particular worker slot that picked up
  the job
* Keep placeholders of non-existing keys when doing the variable
  substitution during job creation on the web UI side (instead of removing
  them) so the worker still sees the placeholder and can do a final
  substitution (removing placeholders of non-existing keys, so the overall
  behavior does not change)
* Do *not* propagate settings from the final substitution back to the web
  UI as the job might be restarted and then run on a different worker where
  settings might be different
* Extend relevant documentation
* See https://progress.opensuse.org/issues/169159
    @Martchus
    Martchus committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2a64912 View commit details
    Browse the repository at this point in the history