Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1403: Create minimal openshift tests extension #1168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+3,279 −8
Open

OTA-1403: Create minimal openshift tests extension #1168

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9529697
cmd: Move CVO CLI to a separate folder
DavidHurta Mar 4, 2025
8757fbb
cmd: Create openshift-tests-extension CLI
DavidHurta Mar 4, 2025
76bf74c
hack/build-go.sh: Build the openshift-tests-extension
DavidHurta Mar 7, 2025
91e1eb9
hack/build-go.sh: Compress the openshift-tests-extension
DavidHurta Mar 7, 2025
3fa9dbf
deps: go mod tidy & go mod vendor
DavidHurta Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 cmd/image.go → cmd/cluster-version-operator/image.go
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The movement of the files could be considered an overkill. I am interested in opinions and suggestions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan actually - but would do it in a separate PR that does nothing else

File renamed without changes.
0 cmd/main.go → cmd/cluster-version-operator/main.go
View file
Open in desktop
File renamed without changes.
0 cmd/render.go → cmd/cluster-version-operator/render.go
View file
Open in desktop
File renamed without changes.
0 cmd/start.go → cmd/cluster-version-operator/start.go
View file
Open in desktop
File renamed without changes.
0 cmd/updatestatuscontroller.go → ...ersion-operator/updatestatuscontroller.go
View file
Open in desktop
File renamed without changes.
0 cmd/version.go → cmd/cluster-version-operator/version.go
View file
Open in desktop
File renamed without changes.
31 changes: 31 additions & 0 deletions cmd/openshift-tests-extension/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package main

import (
"os"

"github.com/spf13/cobra"

"github.com/openshift-eng/openshift-tests-extension/pkg/cmd"
"github.com/openshift-eng/openshift-tests-extension/pkg/extension"
"github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests"
)

func main() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the https://github.com/openshift-eng/openshift-tests-extension/blob/main/cmd/example-tests/main.go example extension

registry := extension.NewRegistry()
ext := extension.NewExtension("openshift", "payload", "cluster-version-operator")

var specs []*extensiontests.ExtensionTestSpec
ext.AddSpecs(specs)
registry.Register(ext)

root := &cobra.Command{
Long: "OpenShift Tests Extension for Cluster Version Operator",
}
root.AddCommand(cmd.DefaultExtensionCommands(registry)...)

if err := func() error {
return root.Execute()
}(); err != nil {
os.Exit(1)
}
}
2 changes: 1 addition & 1 deletion hack/build-go.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ fi
mkdir -p ${BIN_PATH}

echo "Building ${REPO} (${VERSION_OVERRIDE})"
GOOS=${GOOS} GOARCH=${GOARCH} go build ${GOFLAGS} -ldflags "${GLDFLAGS}" -o ${BIN_PATH}/cluster-version-operator ${REPO}/cmd/...
GOOS=${GOOS} GOARCH=${GOARCH} go build ${GOFLAGS} -ldflags "${GLDFLAGS}" -o ${BIN_PATH}/cluster-version-operator ${REPO}/cmd/cluster-version-operator/...