OTA-1403: Create minimal openshift tests extension #1168

DavidHurta · 2025-03-07T15:29:35Z

Create a minimal Cluster Version Operator OpenShift tests extension.

For more information regarding the extension, see openshift-eng/openshift-tests-extension repository or the respective enhancement.

This pull request references https://issues.redhat.com//browse/OTA-1403

Following PRs will:

Include new targets in the Makefile.
- update to run _output/$OS/$ARCH/openshift-tests-extension update
- verify to verify no changes are present after the update invocation
Create a new job to run the verify on presubmits
Create the first test in the extension
Update the Dockerfile to include the extension binary in a payload image
Register the extension in origin
Add remaining tests

openshift-ci · 2025-03-07T15:29:39Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-03-07T15:29:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [DavidHurta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

So that we can have multiple CLI applications in the `cmd` folder.

Create a minimal openshift-tests-extension CLI application, which has no tests. Verifying no tests are present: ```sh $ ./_output/linux/amd64/openshift-tests-extension list null ```

DavidHurta · 2025-03-07T15:32:53Z

cmd/cluster-version-operator/image.go

The movement of the files could be considered an overkill. I am interested in opinions and suggestions.

I'm a fan actually - but would do it in a separate PR that does nothing else

Build a statically compiled openshift-tests-extension binary. Static compilation is done because [1]: > Extension binaries are extracted from container images into a > running Pod executing openshift-tests. Contributors do not > necessarily know which version of RHEL the openshift-tests > binary will be running on, so, for maximum portability, > test extension binaries should be statically compiled. The `GO_COMPLIANCE_POLICY="exempt_all"` is set because [1]: > For compliance reasons, when a binary is compiled by a golang > builder image supplied by ART, a wrapper around the go compiler > will force FIPS compliant compilation (e.g. dynamic linking). > For this reason, extension binaries should include > GO_COMPLIANCE_POLICY="exempt_all" in the environment when > compiling an extension binary. This will inhibit the wrapper from > modifying CGO_ENABLED or other compiler arguments required for > static compilation. Set `CGO_ENABLED=0` to disable the use of cgo. Verifying whether such a binary is built statically: ```sh $ ldd _output/linux/amd64/openshift-tests-extension not a dynamic executable ``` [1]: https://github.com/openshift/enhancements/blob/c2c0d43e3cd70cf79bc2b101ceb6a03c5e0114a8/enhancements/testing/openshift-tests-extension.md

Compress the openshift-tests-extension binary. Use `--force` to overwrite the output file if already present to speed up local development. Use `--keep` to keep the original binary after compressing it so that a developer may use it. Compressing because [1]: > Statically linked binaries are prohibited in FIPS and will > cause failures if detected by product pipeline scans. To > avoid this, extension binaries should be gzipped before > being committed to container images. Such a compressed binary can be then extracted as per [1]: > After discovering a test extension binary, the origin test framework will > extract the binary from the container image which carries it and store it > in /tmp storage of the pod in which it is running. > > If the binary-path ends in .gz, the binary will be decompressed. [1]: https://github.com/openshift/enhancements/blob/c2c0d43e3cd70cf79bc2b101ceb6a03c5e0114a8/enhancements/testing/openshift-tests-extension.md

DavidHurta · 2025-03-07T15:35:27Z

hack/build-go.sh

+echo "Building ${REPO} openshift-tests-extension binary (${VERSION_OVERRIDE})"
+GO_COMPLIANCE_POLICY="exempt_all" CGO_ENABLED=0 GOOS=${GOOS} GOARCH=${GOARCH} \
+go build                                                                      \
+${GOFLAGS}                                                                    \
+-ldflags "${GLDFLAGS}"                                                        \
+-o "${BIN_PATH}/openshift-tests-extension"                                    \
+"${REPO}/cmd/openshift-tests-extension/..."


I am not a skillful go builder. Suggestions and tips are welcomed.

DavidHurta · 2025-03-07T15:38:53Z

/test images

openshift-ci-robot · 2025-03-07T15:39:50Z