Thing Details: Add Copy DSL Definition button #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
copy-dsl-in-thing-details
branch
from
49cfded to
85d905e
Compare
#2912 Bundle Size — 11.07MiB (-0.02%).42f4c67(current) vs d651945 main#2909(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2912 |
Baseline #2909 |
|
|---|---|---|
 Initial JS |
2MiB(~+0.01%) |
2MiB |
 Initial CSS |
577.34KiB |
577.34KiB |
 Cache Invalidation |
19.56% |
18.8% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2948(-0.03%) |
2949 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.71% |
1.71% |
| Packages |
98 |
98 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 2 changes 
2 improvements
| Current #2912 |
Baseline #2909 |
|
|---|---|---|
| JS |
9.29MiB (-0.02%) |
9.29MiB |
| CSS |
867.35KiB (-0.03%) |
867.59KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch jimtng:copy-dsl-in-thing-details Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
copy-dsl-in-thing-details
branch
from
85d905e to
42f4c67
Compare
|
rebased |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Mar 11, 2025
Those were forgotten to submit during review. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on openhab/openhab-core#4569
Resolve openhab/openhab-core#4509
This depends on the changes in api.js and also the rename of
copytoduplicatein #3021Also cleaned up / removed the previous attempt (from 5 years ago) to create a textual definition. It was commented out and wasn't actually used.