Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item details & Items list: Add Copy DSL Definition button #3084

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 3, 2025

Add Copy DSL Definition for items, both in Item Details and Items List using the definition provided by openhab/openhab-core#4569

Resolve openhab/openhab-core#4509

To do this, all the "Copy XXX" (e.g. Copy Item, Copy Rule, Copy Thing, Copy Channel, etc) are renamed to "Duplicate XXX". This will make the distinction extra clear between duplicating vs copying to clipboard. This change is done in a separate commit, so don't squash merge.

Depends on #3021 for the changes in api.js (included here but will be rebased).

image image image

Copy link

relativeci bot commented Mar 3, 2025

#2914 Bundle Size — 11.08MiB (+0.01%).

bb94960(current) vs a229c3d main#2913(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2914
     Baseline
#2913
No change  Initial JS 2MiB 2MiB
No change  Initial CSS 577.34KiB 577.34KiB
Change  Cache Invalidation 18.81% 19.56%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2948 2948
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.71% 1.71%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2914
     Baseline
#2913
Regression  JS 9.29MiB (+0.01%) 9.29MiB
No change  CSS 867.35KiB 867.35KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:items-copy-definitionProject dashboard


Generated by RelativeCIDocumentationReport issue

@lolodomo
Copy link
Contributor

lolodomo commented Mar 3, 2025

For the list, you call the API several times, item by item?

@jimtng
Copy link
Contributor Author

jimtng commented Mar 3, 2025

For the list, you call the API several times, item by item?

yes

afaik the api doesn't support list?

@lolodomo lolodomo added enhancement New feature or request main ui Main UI labels Mar 4, 2025
@florian-h05 florian-h05 added the awaiting other PR Depends on another PR label Mar 10, 2025
@jimtng jimtng force-pushed the items-copy-definition branch from c17fc31 to 9ba3ace Compare March 10, 2025 14:18
@jimtng
Copy link
Contributor Author

jimtng commented Mar 10, 2025

rebased

@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Mar 10, 2025
@florian-h05 florian-h05 force-pushed the items-copy-definition branch from 9ba3ace to 790167b Compare March 11, 2025 19:40
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

FYI I have rebased after merging #3086.

@florian-h05 florian-h05 changed the title Item Details and Items List: Add Copy DSL Definition button Item details & Items list: Add Copy DSL Definition button Mar 11, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Mar 11, 2025
Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 merged commit 6c88932 into openhab:main Mar 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to suggest file syntax for things and items to users
3 participants