-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item details & Items list: Add Copy DSL Definition button #3084
Conversation
#2914 Bundle Size — 11.08MiB (+0.01%).bb94960(current) vs a229c3d main#2913(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jimtng:items-copy-definition Project dashboard Generated by RelativeCI Documentation Report issue |
For the list, you call the API several times, item by item? |
yes afaik the api doesn't support list? |
c17fc31
to
9ba3ace
Compare
rebased |
Signed-off-by: Jimmy Tanagra <[email protected]>
9ba3ace
to
790167b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
FYI I have rebased after merging #3086.
Signed-off-by: Florian Hotze <[email protected]>
Add Copy DSL Definition for items, both in Item Details and Items List using the definition provided by openhab/openhab-core#4569
Resolve openhab/openhab-core#4509
To do this, all the "Copy XXX" (e.g. Copy Item, Copy Rule, Copy Thing, Copy Channel, etc) are renamed to "Duplicate XXX". This will make the distinction extra clear between duplicating vs copying to clipboard. This change is done in a separate commit, so don't squash merge.
Depends on #3021 for the changes in api.js (included here but will be rebased).