Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Bump min policy version #1604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

cmake: Bump min policy version #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jsoncppConfig.cmake.in
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_policy(PUSH)
cmake_policy(VERSION 3.0...3.26)
cmake_policy(VERSION 3.5...3.26)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a CMake guru here, but wanted to add context the issue is we pull this in as a dependency and Github Action runners started used cmake 4.0 from 3.31.6 and that is where this started occuring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think the correct thing would be to bump up the max, not the min?

As long as things build under v3.0, there should be no reason to change the min. That should only happen if the config starts using something that isn't added until a later version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 1.9.6 should be fine with the addition of the max version. You should verify that you actually 1.9.6.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was fixed in September with 1.9.6. Any idea how/when that makes it to the mainline debian respositories? My Ubuntu 22.04.5 install still pulls 1.9.5.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe not the correct forum to discuss Debian/Ubuntu release procedures but in general, these distributions aim to provide a consistent experience where the jsoncpp in them compiles with the CMake in them. They do not generally provide updates. So Ubuntu 22.04 will be forever stuck with 1.9.5, but it also ships with a compatible CMake. (Ubuntu 25.04 will likely be the first to have 1.9.6) If you want to have the latest CMake you also need to make sure to get a consistent environment with that. So use a distro that always has the latest like Arch or the almost latest like Fedora. Or get your dependencies from a different source like vcpkg or similar.


@PACKAGE_INIT@