Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Bump min policy version #1604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arno-lunarg
Copy link

We are getting this error:

 CMake Error at external/Release/64/jsoncpp/build/install/lib/cmake/jsoncpp/jsoncppConfig.cmake:2 (cmake_policy):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
Call Stack (most recent call first):
  CMakeLists.txt:32 (find_package)

Is bumping minimum to 3.5 ok?

@@ -1,5 +1,5 @@
cmake_policy(PUSH)
cmake_policy(VERSION 3.0...3.26)
cmake_policy(VERSION 3.5...3.26)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a CMake guru here, but wanted to add context the issue is we pull this in as a dependency and Github Action runners started used cmake 4.0 from 3.31.6 and that is where this started occuring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think the correct thing would be to bump up the max, not the min?

As long as things build under v3.0, there should be no reason to change the min. That should only happen if the config starts using something that isn't added until a later version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 1.9.6 should be fine with the addition of the max version. You should verify that you actually 1.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants