Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-browser: Update version to 2.24.5 #11910

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Feb 28, 2025

Description

obs-browser: Update version to 2.24.5

082a0a2 - Don't emit a normal call to a function for closing panels
663dc38 - Disable modern game controller API on Windows
4023fad - Log fatal CEF crashes to file
52c1527 - Print browser source renderer crashes to OBS log
af0651b - Log error if CefInitialize fails
8223215 - Revert "Enable Qt message loop on Linux"
16ff0fa - Update version to 2.24.5

Additionally, update buildspec.json and build-aux/modules/99-cef.json to use the new CEF builds. This is being done because the changes in obs-browser specifically are meant to work with a CEF build compiled with use_gtk=false.

Motivation and Context

Fixes #11485
Fixes obsproject/obs-browser#468

How Has This Been Tested?

Tested on obsproject/obs-browser#472 and off-thread by others.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Feb 28, 2025
@RytoEX RytoEX added this to the OBS Studio 31.0 milestone Feb 28, 2025
@RytoEX RytoEX self-assigned this Feb 28, 2025
@RytoEX RytoEX added the Seeking Testers Build artifacts on CI label Feb 28, 2025
Copy link
Collaborator

@tytan652 tytan652 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Flatpak side, and Flatpak CI is good ignoring Crowdin shenanigans.

082a0a2 - Don't emit a normal call to a function for closing panels
663dc38 - Disable modern game controller API on Windows
4023fad - Log fatal CEF crashes to file
52c1527 - Print browser source renderer crashes to OBS log
af0651b - Log error if CefInitialize fails
8223215 - Revert "Enable Qt message loop on Linux"
16ff0fa - Update version to 2.24.5

Additionally, update buildspec.json and build-aux/modules/99-cef.json to
use the new CEF builds. This is being done because the changes in
obs-browser specifically are meant to work with a CEF build compiled
with use_gtk=false.
@RytoEX RytoEX force-pushed the update-obs-browser branch from c6b9a3d to 2d4758f Compare February 28, 2025 22:17
Copy link
Member

@WizardCM WizardCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it correctly downloads the updated dep on Windows. All hashes look correct. Submodule changes look good too.

@RytoEX RytoEX merged commit 3d9d066 into obsproject:master Mar 3, 2025
14 checks passed
@RytoEX RytoEX deleted the update-obs-browser branch March 3, 2025 20:39
@RytoEX RytoEX mentioned this pull request Mar 7, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Seeking Testers Build artifacts on CI
Projects
None yet
3 participants