Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks to release/31.0 #11934

Merged
merged 10 commits into from
Mar 7, 2025
Merged

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Mar 7, 2025

Description

Cherry-picks:

Motivation and Context

Want to ship crash fixes and bug fixes.

How Has This Been Tested?

Tested on the PRs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

jcm93 and others added 10 commits March 7, 2025 14:04
This updates checks against current SDK redist versions:
- 0.7.6 (Video Effects)
- 1.6.1.2 (Audio Effects)

Users will receive a warning if their redist versions are lower than
these.

Signed-off-by: pkv <[email protected]>
(cherry picked from commit 417eddf)
We don't use CUDA RT functions anymore.
So this commit removes their loading from the CUDA RT DLL.
This also fixes a crash when loading different versions of CUDA RT when
the SDK is updated [1].

[1] obsproject#11813

Signed-off-by: pkv <[email protected]>
(cherry picked from commit d1249cd)
The regexp was not tolerating a + sign is the version string,
causing configuration to fail on Ubuntu 24.04 when the installed
version is 6.1.1-3ubuntu5+esm2.

(cherry picked from commit 9b97d48)
This was logging an intermediate value, rather than the final lookahead
depth value after all calculations. Log the final value instead.

(cherry picked from commit a8a349c)
082a0a2 - Don't emit a normal call to a function for closing panels
663dc38 - Disable modern game controller API on Windows
4023fad - Log fatal CEF crashes to file
52c1527 - Print browser source renderer crashes to OBS log
af0651b - Log error if CefInitialize fails
8223215 - Revert "Enable Qt message loop on Linux"
16ff0fa - Update version to 2.24.5

Additionally, update buildspec.json and build-aux/modules/99-cef.json to
use the new CEF builds. This is being done because the changes in
obs-browser specifically are meant to work with a CEF build compiled
with use_gtk=false.

(cherry picked from commit 3d9d066)
If a frame has a width or height of zero, this value will make it into
libobs/media-io/video-frame.c:video_frame_init and cause linesizes or
heights to be zero, which will result in a bmalloc(0) call and OBS will
crash.

Instead of letting the call stack get that far, check the frame width
and height here at the source, log an error, and return early if the
frame width or height are zero.

(cherry picked from commit 3437e2b)
@RytoEX RytoEX added the Seeking Testers Build artifacts on CI label Mar 7, 2025
@RytoEX RytoEX added this to the OBS Studio 31.0 milestone Mar 7, 2025
@RytoEX RytoEX requested a review from PatTheMav March 7, 2025 19:13
@RytoEX RytoEX self-assigned this Mar 7, 2025
@RytoEX RytoEX merged commit 2b6bacd into obsproject:release/31.0 Mar 7, 2025
@RytoEX RytoEX deleted the 31-0-2-cherry-picks branch March 7, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Seeking Testers Build artifacts on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants