Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error in PowerPoint slideshows when focus highlighting is on #17724

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −2
Open

Avoid error in PowerPoint slideshows when focus highlighting is on #17724

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae763a0
Avoid error in PowerPoint slideshows when focus highlighting is on
LeonarddeR Feb 21, 2025
76d99fb
Update source/appModules/powerpnt.py
LeonarddeR Feb 25, 2025
0ea3151
Fix type hint
LeonarddeR Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions source/appModules/powerpnt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2012-2024 NV Access Limited, Leonard de Ruijter
# Copyright (C) 2012-2025 NV Access Limited, Leonard de Ruijter
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.

Expand Down Expand Up @@ -41,7 +41,7 @@
from controlTypes import TextPosition
from logHandler import log
import scriptHandler
from locationHelper import RectLTRB
from locationHelper import RectLTRB, RectLTWH
from NVDAObjects.window._msOfficeChart import OfficeChart
from utils.urlUtils import _LinkData

Expand Down Expand Up @@ -1360,6 +1360,11 @@ class SlideShowTreeInterceptorTextInfo(NVDAObjectTextInfo):
def _getStoryText(self):
return self.obj.rootNVDAObject.basicText

def _get_boundingRects(self) -> list[RectLTWH]:
if self.obj.rootNVDAObject.hasIrrelevantLocation:
raise LookupError("Object is off screen, invisible or has no location")
return [self.obj.rootNVDAObject.location]

def _getOffsetsFromNVDAObject(self, obj):
if obj == self.obj.rootNVDAObject:
return (0, self._getStoryLength())
Expand Down