Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error in PowerPoint slideshows when focus highlighting is on #17724

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

NVDA raises the following error when the highlighter is on in a PowerPoint slide show

Error running handler <bound method NVDAHighlighter.handleBrowseModeMove of <visionEnhancementProviders.NVDAHighlighter.NVDAHighlighter object at 0x088D25D0>> for <extensionPoints.Action object at 0x0640C350>
Traceback (most recent call last):
  File "extensionPoints\__init__.pyc", line 56, in notify
  File "extensionPoints\util.pyc", line 216, in callWithSupportedKwargs
  File "visionEnhancementProviders\NVDAHighlighter.pyc", line 497, in handleBrowseModeMove
  File "visionEnhancementProviders\NVDAHighlighter.pyc", line 481, in updateContextRect
  File "vision\util.pyc", line 79, in getContextRect
  File "vision\util.pyc", line 48, in getCaretRect
  File "vision\util.pyc", line 94, in getRectFromTextInfo
  File "baseObject.pyc", line 39, in __get__
  File "NVDAObjects\__init__.pyc", line 72, in _get_boundingRects
AttributeError: 'ReviewableSlideshowTreeInterceptor' object has no attribute 'hasIrrelevantLocation'

Description of user facing changes

No longer an error in the log

Description of development approach

Added an override of boundingRects on SlideShowTreeInterceptorTextInfo

Testing strategy:

Ensured that the error no longer occurs.

Known issues with pull request:

I didn't add a changelog error as this was only revealed by an error sound, and the release versions of NVDA have their error sound disabled, so this is an invisible bug.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner February 21, 2025 13:34
@AppVeyorBot
Copy link

  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit a6b0ea416b

@hwf1324
Copy link
Contributor

hwf1324 commented Feb 21, 2025

Related: #15461

@LeonarddeR
Copy link
Collaborator Author

This pr doesn't fix #15461. Browse mode in powerpoint is simply based on presenting the text of a slide in browse mode, therefore information about the position of the caret is not available.

@hwf1324
Copy link
Contributor

hwf1324 commented Feb 22, 2025

This pr doesn't fix #15461. Browse mode in powerpoint is simply based on presenting the text of a slide in browse mode, therefore information about the position of the caret is not available.

That means this PR just eliminates the error in the log?

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 24, 2025
@AppVeyorBot
Copy link

See test results for failed build of commit 70e823ced0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants