Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: replace ansi clear with ansi reset #55013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmarchini
Copy link
Contributor

@pmarchini pmarchini commented Sep 19, 2024

Fixes: #55009

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module. labels Sep 19, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Sep 19, 2024

Not for this PR, but is colors.clear worth having at all? I'm not sure if it's used elsewhere, and it seems like a possible footgun, as evidenced by this bug.

@pmarchini
Copy link
Contributor Author

I'm going to check if it's used elsewhere, but yes, it's definitely risky

@RedYetiDev
Copy link
Member

Great work @pmarchini! LGTM

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (0d4387e) to head (9428d7c).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55013   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         652      652           
  Lines      183765   183766    +1     
  Branches    35863    35862    -1     
=======================================
+ Hits       161789   161800   +11     
- Misses      15229    15231    +2     
+ Partials     6747     6735   -12     
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/dot.js 100.00% <100.00%> (ø)
lib/internal/util/colors.js 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 19, 2024
@cjihrig cjihrig linked an issue Sep 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dot reporter causes the terminal to clear since Node v22.8.0
7 participants