Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot reporter causes the terminal to clear since Node v22.8.0 #55009

Closed
adrienjoly opened this issue Sep 19, 2024 · 5 comments · Fixed by #55013
Closed

dot reporter causes the terminal to clear since Node v22.8.0 #55009

adrienjoly opened this issue Sep 19, 2024 · 5 comments · Fixed by #55013
Labels
confirmed-bug Issues with confirmed bugs. regression Issues related to regressions. test_runner Issues and PRs related to the test runner subsystem. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Comments

@adrienjoly
Copy link

Version

22.8.0

Platform

arwin MBP-AJ-2023.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020 arm64

Subsystem

No response

What steps will reproduce the bug?

Create an empty repro.test.js file.

Run:

node --test-reporter=dot --test repro.test.js

=> the terminal clears

Whereas it doesn't, when --test-reporter=dot is not provided.

Both cases were working fine with Node v22.5.1.

How often does it reproduce? Is there a required condition?

Systematically.

What is the expected behavior? Why is that the expected behavior?

The terminal should not clear, so the test results and stdout from previous commands remain on screen.

What do you see instead?

Blank terminal window.

Additional information

No response
@pmarchini
Copy link
Member

able to reproduce @RedYetiDev

@RedYetiDev RedYetiDev added repro-exists Issues with reproductions. regression Issues related to regressions. test_runner Issues and PRs related to the test runner subsystem. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 19, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 19, 2024 •
edited
Loading

@nodejs/test_runner - sounds like a simple fix, that is, assuming this is just one statement that clears the screen?

@pmarchini
Copy link
Member

I'm taking a look

@cjihrig
Copy link
Contributor

cjihrig commented Sep 19, 2024

My guess is #53450 introducing colors.clear in the dot reporter is the culprit, but I have not tested.

@pmarchini
Copy link
Member

@cjihrig, just tried, yes, the root cause is clear

@pmarchini pmarchini mentioned this issue Sep 19, 2024
Merged
@cjihrig cjihrig linked a pull request Sep 19, 2024 that will close this issue
test_runner: replace ansi clear with ansi reset #55013
Merged
@RedYetiDev RedYetiDev added confirmed-bug Issues with confirmed bugs. and removed repro-exists Issues with reproductions. labels Sep 21, 2024
targos pushed a commit that referenced this issue Oct 4, 2024
@pmarchini @targos
test_runner: replace ansi clear with ansi reset
4b962a7 
PR-URL: #55013
Fixes: #55009
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@pmarchini @louwers
test_runner: replace ansi clear with ansi reset
d855cf5 
PR-URL: nodejs#55013
Fixes: nodejs#55009
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. regression Issues related to regressions. test_runner Issues and PRs related to the test runner subsystem. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_runner: replace ansi clear with ansi reset pmarchini/node
4 participants
@adrienjoly @cjihrig @RedYetiDev @pmarchini