Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: replace ansi clear with ansi reset #55013

Merged
merged 1 commit into from
Sep 21, 2024
Merged

test_runner: replace ansi clear with ansi reset #55013

merged 1 commit into from
Sep 21, 2024

Conversation

pmarchini
Copy link
Member

@pmarchini pmarchini commented Sep 19, 2024 •
edited
Loading

Fixes: #55009

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module. labels Sep 19, 2024
@cjihrig
Copy link
Contributor

cjihrig commented Sep 19, 2024

Not for this PR, but is colors.clear worth having at all? I'm not sure if it's used elsewhere, and it seems like a possible footgun, as evidenced by this bug.

@pmarchini
Copy link
Member Author

I'm going to check if it's used elsewhere, but yes, it's definitely risky

@RedYetiDev
Copy link
Member

Great work @pmarchini! LGTM

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62563/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (0d4387e) to head (9428d7c).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55013   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         652      652           
  Lines      183765   183766    +1     
  Branches    35863    35862    -1     
=======================================
+ Hits       161789   161800   +11     
- Misses      15229    15231    +2     
+ Partials     6747     6735   -12
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/dot.js 100.00% <100.00%> (ø)
lib/internal/util/colors.js 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Sep 19, 2024
@cjihrig cjihrig linked an issue Sep 19, 2024 that may be closed by this pull request
dot reporter causes the terminal to clear since Node v22.8.0 #55009
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0c8c107 into nodejs:main Sep 21, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c8c107

targos pushed a commit that referenced this pull request Oct 4, 2024
@pmarchini @targos
test_runner: replace ansi clear with ansi reset
4b962a7 
PR-URL: #55013
Fixes: #55009
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@pmarchini @louwers
test_runner: replace ansi clear with ansi reset
d855cf5 
PR-URL: nodejs#55013
Fixes: nodejs#55009
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@MoLow MoLow MoLow approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test_runner Issues and PRs related to the test runner subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dot reporter causes the terminal to clear since Node v22.8.0
7 participants
@pmarchini @nodejs-github-bot @cjihrig @RedYetiDev @benjamingr @MoLow @atlowChemi